-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conformance: Allow 405 Status for all tear down / deletes #179
Comments
@jdolitsky friendly bump |
@markphelps I think that this is reasonable. To clarify - you're talking specifically about the conformance tests and not changing error codes listed here https://github.com/opencontainers/distribution-spec/blob/master/spec.md#endpoints ? |
@jdolitsky yup correct. just talking about changing the conformance tests to allow for |
I can happily create a PR as well if you like |
@markphelps PR would be great :) |
Much like what was implemented in https://github.com/opencontainers/distribution-spec/pull/151/files#diff-fddb7a1636af89303c8fcf32651486a9R260 for
02_push_test.go
, it would be great if you could allow this for all the other tests.For example, our registry does not currently support deletion through the CLI, so all of the other tests are failing in the tear down step with errors such as:
It seems like
HTTP 405
s should be allowed in the teardown of the following tests:01_pull_test.go
03_discovery_test.go
04_management_test.go
Thanks!
The text was updated successfully, but these errors were encountered: