[centos7] not ok 76 runc start

[kolyshkin]

The following failure happened on GHA under CentOS 7 (from https://github.com/opencontainers/runc/pull/2852/checks?check_run_id=2134946430):

not ok 76 runc start
# (in test file tests/integration/start.bats, line 29)
#   `[ "$status" -ne 0 ]' failed
# runc spec (status=0):
# 
# runc create --console-socket /tmp/bats-run-20084/runc.S5XyCu/tty/sock test_busybox (status=0):
# 
# runc state test_busybox (status=0):
# {
#   "ociVersion": "1.0.2-dev",
#   "id": "test_busybox",
#   "pid": 28323,
#   "status": "created",
#   "bundle": "/tmp/bats-run-20084/runc.S5XyCu/bundle",
#   "rootfs": "/tmp/bats-run-20084/runc.S5XyCu/bundle/rootfs",
#   "created": "2021-03-17T22:05:39.428887171Z",
#   "owner": ""
# }
# runc start test_busybox (status=0):
# 
# runc state test_busybox (status=0):
# {
#   "ociVersion": "1.0.2-dev",
#   "id": "test_busybox",
#   "pid": 28323,
#   "status": "running",
#   "bundle": "/tmp/bats-run-20084/runc.S5XyCu/bundle",
#   "rootfs": "/tmp/bats-run-20084/runc.S5XyCu/bundle/rootfs",
#   "created": "2021-03-17T22:05:39.428887171Z",
#   "owner": ""
# }
# runc delete --force test_busybox (status=1):
# time="2021-03-17T22:05:54Z" level=error msg="container init still running"
# runc state test_busybox (status=0):
# {
#   "ociVersion": "1.0.2-dev",
#   "id": "test_busybox",
#   "pid": 28323,
#   "status": "running",
#   "bundle": "/tmp/bats-run-20084/runc.S5XyCu/bundle",
#   "rootfs": "/tmp/bats-run-20084/runc.S5XyCu/bundle/rootfs",
#   "created": "2021-03-17T22:05:39.428887171Z",
#   "owner": ""
# }

Looking at the code, I can't imagine how this may happen, and yet I see a few minor issues which need attention.

[kolyshkin]

Got another one, from https://github.com/opencontainers/runc/pull/2871/checks?check_run_id=2193862445

not ok 77 runc start
# (in test file tests/integration/start.bats, line 29)
#   `[ "$status" -ne 0 ]' failed
# runc spec (status=0):
# 
# runc create --console-socket /tmp/bats-run-7671/runc.JILTwc/tty/sock test_busybox (status=0):
# 
# runc state test_busybox (status=0):
# {
#   "ociVersion": "1.0.2-dev",
#   "id": "test_busybox",
#   "pid": 16389,
#   "status": "created",
#   "bundle": "/tmp/bats-run-7671/runc.JILTwc/bundle",
#   "rootfs": "/tmp/bats-run-7671/runc.JILTwc/bundle/rootfs",
#   "created": "2021-03-25T14:20:01.223686332Z",
#   "owner": ""
# }
# runc start test_busybox (status=0):
# 
# runc state test_busybox (status=0):
# {
#   "ociVersion": "1.0.2-dev",
#   "id": "test_busybox",
#   "pid": 16389,
#   "status": "running",
#   "bundle": "/tmp/bats-run-7671/runc.JILTwc/bundle",
#   "rootfs": "/tmp/bats-run-7671/runc.JILTwc/bundle/rootfs",
#   "created": "2021-03-25T14:20:01.223686332Z",
#   "owner": ""
# }
# runc delete --force test_busybox (status=1):
# time="2021-03-25T14:20:14Z" level=error msg="container init still running"
# runc state test_busybox (status=0):
# {
#   "ociVersion": "1.0.2-dev",
#   "id": "test_busybox",
#   "pid": 16389,
#   "status": "running",
#   "bundle": "/tmp/bats-run-7671/runc.JILTwc/bundle",
#   "rootfs": "/tmp/bats-run-7671/runc.JILTwc/bundle/rootfs",
#   "created": "2021-03-25T14:20:01.223686332Z",
#   "owner": ""
# }