Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent size values in example #580

Closed
RobDolinMS opened this issue Sep 19, 2016 · 3 comments
Closed

Inconsistent size values in example #580

RobDolinMS opened this issue Sep 19, 2016 · 3 comments

Comments

@RobDolinMS
Copy link
Collaborator

There are two instances of uidMappings in the spec and they have wildly different values for "size" (10 and 3200)

Is this intentional or possibly an error?

(Same applies for gidMappings)
@wking
Copy link
Contributor

wking commented Sep 19, 2016

On Mon, Sep 19, 2016 at 03:34:04PM -0700, Rob Dolin (MSFT) wrote:

There are two instances of uidMappings in the spec and they have
wildly different values for "size" (10 and 3200)

Is this intentional or possibly an error?

Both are potentially valid. The @mrunalp suggested 32k [1](although
I haven't been able to turn up a reason). I don't remember anyone
advocating for 10, so I'm fine going with 32000 in all of our mapping
examples.

@RobDolinMS
Copy link
Collaborator Author

Proposed #613 to resolve this.

@cyphar
Copy link
Member

cyphar commented Nov 13, 2016

#613 has been merged (so this should be closed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wking @crosbymichael @cyphar @RobDolinMS