-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(roThresholdLimit): add ROThresholdLimit support in pool manager #15
Merged
sonasingh46
merged 4 commits into
openebs-archive:master
from
mittachaitu:fix_ro_threshold_limit
Mar 23, 2020
Merged
feat(roThresholdLimit): add ROThresholdLimit support in pool manager #15
sonasingh46
merged 4 commits into
openebs-archive:master
from
mittachaitu:fix_ro_threshold_limit
Mar 23, 2020
+166
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd65e4b
to
e1d33c5
Compare
sonasingh46
reviewed
Mar 18, 2020
sonasingh46
reviewed
Mar 18, 2020
sonasingh46
reviewed
Mar 18, 2020
sonasingh46
reviewed
Mar 18, 2020
sonasingh46
reviewed
Mar 18, 2020
sonasingh46
reviewed
Mar 18, 2020
sonasingh46
reviewed
Mar 18, 2020
sonasingh46
reviewed
Mar 18, 2020
e1d33c5
to
9c5f16f
Compare
Signed-off-by: mittachaitu <[email protected]>
Signed-off-by: mittachaitu <[email protected]>
Signed-off-by: mittachaitu <[email protected]>
9c5f16f
to
5563eae
Compare
Signed-off-by: mittachaitu <[email protected]>
sonasingh46
approved these changes
Mar 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mittachaitu [email protected]
This PR adds support for ROThresholdLimit in the pool manager.
Note:
roThresholdLimit
is set to0
or100
:Sample CSPI spec and status when pool in RW state
Sample CSPI spec and status when pool is in RO mode
Events Generation:
TODO:
Fix travis after PR in api got merged.