-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): update README and quick.md files #154
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekpandey14
force-pushed
the
update-docs
branch
from
August 11, 2020 15:45
9696923
to
c99f25b
Compare
Signed-off-by: prateekpandey14 <[email protected]>
prateekpandey14
force-pushed
the
update-docs
branch
from
August 12, 2020 09:16
c99f25b
to
37cc61f
Compare
prateekpandey14
changed the title
chore(docs): update README with volume specific info
chore(docs): update README and quick.md files
Aug 12, 2020
prateekpandey14
added
the
documentation
Improvements or additions to documentation
label
Aug 12, 2020
mittachaitu
approved these changes
Aug 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes are good
cpu: "250m" | ||
limits: | ||
memory: "128Mi" | ||
memory: "4Gi" | ||
cpu: "500m" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure do we need to specify the show CPU limits?
sonasingh46
reviewed
Aug 12, 2020
sonasingh46
reviewed
Aug 12, 2020
sonasingh46
reviewed
Aug 12, 2020
sonasingh46
reviewed
Aug 12, 2020
Signed-off-by: prateekpandey14 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: prateekpandey14 [email protected]