-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(operator): bump k8s csi to latest stable container images #218
Merged
payes
merged 1 commit into
openebs-archive:master
from
prateekpandey14:update-operators
Jan 10, 2021
Merged
chore(operator): bump k8s csi to latest stable container images #218
payes
merged 1 commit into
openebs-archive:master
from
prateekpandey14:update-operators
Jan 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edd1f20
to
641f7bb
Compare
641f7bb
to
9a33570
Compare
- Bump k8s csi sidecar container image to latest stable releases minimum kubernetes version to support 1.17 - Remove the deprecated Cluster Driver Registrar container, no longer required since the `CSIDriver` object instance should be created by CSI driver installer (or manually) - Update the Snapshot specific CRDs to `V1` version - Remove the `--provisioner` flag not required (not present) in new version of csi-provisioner - Added the `--default-fstype` flag required to be set new csi-provisioner release Signed-off-by: prateekpandey14 <[email protected]>
9a33570
to
6bd3387
Compare
akhilerm
reviewed
Jan 8, 2021
akhilerm
reviewed
Jan 8, 2021
akhilerm
reviewed
Jan 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given some comments.
payes
approved these changes
Jan 10, 2021
akhilerm
reviewed
Jan 11, 2021
- driver | ||
type: object | ||
served: true | ||
storage: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the v1 version not the storage version? @prateekpandey14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Bump k8s csi sidecar container image to latest stable releases minimum kubernetes version to support 1.17
Remove the deprecated Cluster Driver Registrar container which is no longer required since the
CSIDriver
object instance should be created by CSI driver installer (or manually)Update the Snapshot specific CRDs to
V1
versionRemove the
--provisioner
flag not required (not present)in new version of csi-provisioner
Added the
--default-fstype
flag required to be set newcsi-provisioner release
Signed-off-by: prateekpandey14 [email protected]