chore(actions): move travis tests to github actions #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shubham <[email protected]>
shubham14bajpai
force-pushed
the
minikube
branch
from
b4eaa17 to
832e072
Compare
Signed-off-by: shubham <[email protected]>
shubham14bajpai
force-pushed
the
minikube
branch
from
832e072 to
f9d6d15
Compare
Signed-off-by: shubham <[email protected]>
akhilerm
reviewed
Jan 6, 2021
Signed-off-by: shubham <[email protected]>
akhilerm
reviewed
Jan 7, 2021
akhilerm
reviewed
Jan 7, 2021
| run: make test | ||
|
|
||
| e2e-tests: | ||
| needs: ['unit-tests'] |
There was a problem hiding this comment.
@shubham14bajpai Do we need e2e to be dependent on unit-tests. ?
IMHO, lint, unit-tests and e2e-tests can be run in parallel. Only the final build/push needs to be dependent on all these 3 jobs.
There was a problem hiding this comment.
I think checking the modules using make deps and running unit tests to check for syntactical errors is good before building and running the images.
akhilerm
reviewed
Jan 7, 2021
akhilerm
reviewed
Jan 7, 2021
Signed-off-by: shubham <[email protected]>
kmova
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shubham [email protected]
This PR moves the sanity tests from travis to github actions by deploying a minikube using https://github.com/marketplace/actions/setup-minikube-kubernetes-cluster
Got the above action from https://github.com/eclipse/jkube/blob/master/.github/workflows/e2e-tests.yml