Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(resize): add resize test cases when replicas are in different states #311

Merged
merged 4 commits into from
Mar 5, 2020
Merged

fix(resize): add resize test cases when replicas are in different states #311

merged 4 commits into from
Mar 5, 2020

Conversation

mittachaitu
Copy link

Signed-off-by: mittachaitu [email protected]
This PR adds different test cases to cover resize functionality.

Following are the test cases:

  • When replicas are not connected trigger resize and expect iscsi disk of the same size after replicas are connected(offline resize).
  • When all the replicas are in degraded state triggering resize.
  • When only two replicas are connected out of three replicas then triggering resize.
  • When only one replica is connected out of three replicas then triggering resize.

@vishnuitta vishnuitta requested a review from mynktl March 5, 2020 07:45
mynktl
mynktl reviewed Mar 5, 2020
View reviewed changes
test_istgt.sh Outdated Show resolved Hide resolved
vishnuitta
vishnuitta approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@vishnuitta vishnuitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good

@vishnuitta vishnuitta merged commit 480290b into openebs-archive:replication Mar 5, 2020
mynktl
mynktl reviewed Mar 5, 2020
View reviewed changes
Copy link
Contributor

@mynktl mynktl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mynktl mynktl mynktl left review comments

@vishnuitta vishnuitta vishnuitta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mittachaitu @vishnuitta @mynktl