Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ineffectual assignments in udev_test.go #167

Merged
merged 1 commit into from
Nov 2, 2018
Merged

Remove ineffectual assignments in udev_test.go #167

merged 1 commit into from
Nov 2, 2018

Conversation

seanprashad
Copy link

@seanprashad seanprashad commented Oct 24, 2018

Fixes #166

According to the Go Report Card for this project, there are two occurrences where the err variables are declared, but not used:

image

According to the Go Report Card for this project, there are two
occurrences where the err variables are declared, but not used.

Signed-off-by: Sean Prashad <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #167 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #167   +/-   ##
=======================================
  Coverage   54.31%   54.31%           
=======================================
  Files          42       42           
  Lines        1598     1598           
=======================================
  Hits          868      868           
  Misses        668      668           
  Partials       62       62

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02ea053...4fb53c3. Read the comment docs.

@seanprashad
Copy link
Author

Hey @sagarkrsd 👋🏽 I was wondering if you could please review this when you have a moment!

If there's anything I can do to help polish up my PR, please let me know 😁

Copy link
Contributor

@sagarkrsd sagarkrsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanprashad Thanks for your PR !
Looks good to me !

Copy link
Contributor

@shovanmaity shovanmaity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sagarkrsd sagarkrsd merged commit 12c844f into openebs-archive:master Nov 2, 2018
@seanprashad seanprashad deleted the issue-166 branch November 2, 2018 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants