chore(dep): bumps go version to 1.19 #681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update go.mod / go.sum - update vendor directory - update build base image with go 1.19.3 Signed-off-by: Akhil Mohan <[email protected]>
Signed-off-by: Akhil Mohan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #681 +/- ##
===========================================
+ Coverage 45.01% 45.19% +0.17%
===========================================
Files 79 79
Lines 3992 3992
===========================================
+ Hits 1797 1804 +7
+ Misses 2028 2023 -5
+ Partials 167 165 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Akhil Mohan <[email protected]>
|
CI changes in PR #682. |
niladrih
reviewed
Dec 10, 2022
@niladrih Arent we not keeping the vendor directory upto date now? I think with latest go version that should also work |
|
@akhilerm -- The vendor directory was required prior to go modules. We should be able to build without it... |
|
The changes are included in #682 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akhil Mohan [email protected]
Pull Request template
Why is this PR required? What issue does it fix?:
build was using a deprecated version of golang
What this PR does?:
Does this PR require any upgrade changes?: No
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>