feat(migration): add snapshot migration support for cstor #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shubham <[email protected]>
Signed-off-by: shubham <[email protected]>
Signed-off-by: shubham <[email protected]>
| goto retry | ||
| } | ||
| if *newSnap.Status.BoundVolumeSnapshotContentName != snapContent.Name { | ||
| return errors.Errorf("volumesnapshot %s is bound to incorrect volumesnapshotcontent: expected %s got %s", |
There was a problem hiding this comment.
can we also add ReadyToUse : true check as well ?
mittachaitu
reviewed
Jun 12, 2020
| // snapclientset.NewForConfig creates a new Clientset for VolumesnapshotV1beta1Client | ||
| s.snapClient, err = snapclientset.NewForConfig(cfg) | ||
| if err != nil { | ||
| klog.Fatalf("Failed to create snapshot client: %v", err) |
There was a problem hiding this comment.
nit: failed to get snapshot client
| return errors.Wrapf(err, "failed to validate new volumesnapshot %s", newSnap.Name) | ||
| } | ||
| klog.Infof("Cleaing up old volumesnapshot %s", oldSnap.Name) | ||
| err = snap.NewKubeClient().WithNamespace(oldSnap.Namespace).Delete(oldSnap.Name, &metav1.DeleteOptions{}) |
There was a problem hiding this comment.
Add a note saying, users should perform migration only from latest version of OpenEBS.
Signed-off-by: shubham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for migrating snapshots from
volumesnapshot.external-storage.k8s.io/v1tosnapshot.storage.k8s.io/v1beta1spec.