feat(migrate): add support to correct blockdevices in spc before migration #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
migration Signed-off-by: shubham <[email protected]>
Signed-off-by: shubham <[email protected]>
akhilerm
reviewed
Sep 24, 2020
- it also fixes the idempotent nature of the job when adding annotation to spc Signed-off-by: shubham <[email protected]>
Signed-off-by: shubham <[email protected]>
Signed-off-by: shubham <[email protected]>
Signed-off-by: shubham <[email protected]>
Signed-off-by: shubham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shubham [email protected]
This PR adds support for auto-correction of blockdevices in SPC before migration.
This case occurs if the underlying disks used are virtual disk and the spc was created in a version prior to 2.0.0 (the blockdevice issue was fixed in 2.0.0 release)
The changes make the migration job intelligent enough to find out the renamed blockdevices and update those in CSP and SPC before proceeding with the migration.
Local test performed:
Tested the following scenario for devlink based bds:
Tested the following scenarios for path based bds:
Scenario 1:
Scenario 2:
Scenario 3:
The spc and csp were updated with the correct blockdevices and job was successful.