Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove pluggy constraint #189

Merged
merged 1 commit into from
Sep 1, 2021
Merged

fix: remove pluggy constraint #189

merged 1 commit into from
Sep 1, 2021

Conversation

ghassanmas
Copy link
Member

Pytest have released 6.2.5 two days ago: release note : https://docs.pytest.org/en/6.2.x/changelog.html#pytest-6-2-5-2021-08-29

@openedx-webhooks
Copy link

Thanks for the pull request, @ghassanmas! I've created OSPR-6008 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Sep 1, 2021
@ghassanmas
Copy link
Member Author

Here is where the make upgrate is being breaking at this branch openedx/xblock-in-video-quiz#24,
Here is the expected output error

@nedbat
Copy link
Contributor

nedbat commented Sep 1, 2021

I ran a "make upgrade", and it succeeded without conflicts.

@nedbat nedbat merged commit 01b8b22 into openedx:master Sep 1, 2021
@ghassanmas
Copy link
Member Author

@nedbat all good, thank you for the quick response 🙏

@natabene
Copy link

natabene commented Sep 3, 2021

@ghassanmas Thank you for your contribution!

@openedx-webhooks
Copy link

@ghassanmas 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants