For api requests, the jwt token is not in the cookie #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
edx_rbac/utils.py
Outdated
| @@ -50,7 +52,7 @@ def get_decoded_jwt_from_request(request): | |||
| Returns a decoded jwt dict if it finds it. | |||
| Returns a None if it does not. | |||
| """ | |||
| jwt_cookie = request.COOKIES.get(jwt_cookie_name(), None) | |||
| jwt_cookie = request.COOKIES.get(jwt_cookie_name(), None) or request.auth | |||
There was a problem hiding this comment.
Had a look here. I suspect for the sake of testing it might make sense just to mock request.auth (because tests dont use the same auth as in prod)
brittneyexline
force-pushed
the
bexline/add_request_auth
branch
from
a3a6b75 to
e68ddca
Compare
brittneyexline
force-pushed
the
bexline/add_request_auth
branch
from
e68ddca to
69d8b44
Compare
christopappas
approved these changes
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing openedx/edx-enterprise#444, it turns out that we can find the jwt token at
request.authwhen hitting the api directly, and not on the cookie.