Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: browser header showing null #1168

Merged
merged 1 commit into from
Feb 27, 2024
Merged

fix: browser header showing null #1168

merged 1 commit into from
Feb 27, 2024

Conversation

attiyaIshaque
Copy link
Contributor

@attiyaIshaque attiyaIshaque commented Feb 26, 2024

Description

When accessing Authn MFE for the first time it shows “Auth | null” in the browser header. In this PR we fix If process.env.SITE_NAME is not available it will show “Authn” otherwise show “Authn | ”

Backport PR: #1170

JIRA

VAN-1839

How Has This Been Tested?

Please describe in detail how you tested your changes.

Screenshots/sandbox (optional):

Before After
Screenshot 2024-02-26 at 3 53 42 PM Screenshot 2024-02-26 at 4 02 39 PM

@attiyaIshaque attiyaIshaque requested a review from a team as a code owner February 26, 2024 11:03
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.23%. Comparing base (9b04614) to head (4758cd4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1168   +/-   ##
=======================================
  Coverage   84.23%   84.23%           
=======================================
  Files         127      127           
  Lines        2392     2392           
  Branches      678      678           
=======================================
  Hits         2015     2015           
  Misses        357      357           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@attiyaIshaque attiyaIshaque force-pushed the attiya/VAN-1839 branch 2 times, most recently from da12e29 to e5f6ee7 Compare February 26, 2024 11:17
Copy link
Contributor

@syedsajjadkazmii syedsajjadkazmii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: its totally up to you if you think its more readable

<title><%= 'Authn' + (process.env.SITE_NAME ? ' | ' + process.env.SITE_NAME : '') %></title>

@attiyaIshaque attiyaIshaque merged commit e1f4898 into master Feb 27, 2024
7 checks passed
@attiyaIshaque attiyaIshaque deleted the attiya/VAN-1839 branch February 27, 2024 07:52
@regisb
Copy link
Contributor

regisb commented Feb 28, 2024

Can I suggest you also update the MFE template itself? https://github.com/openedx/frontend-template-application/blob/master/public/index.html this is the reference repo that is used to generate all MFE repos.

@hinakhadim
Copy link
Contributor

Can I suggest you also update the MFE template itself? https://github.com/openedx/frontend-template-application/blob/master/public/index.html this is the reference repo that is used to generate all MFE repos.

Updated in frontend-template-application

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants