fix: fix simplify registration experiment bugs

[syedsajjadkazmii]

Description

Fix experiment initialization bug

[codecov]

Codecov Report

Attention: Patch coverage is 23.33333% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 84.23%. Comparing base (e0d6055) to head (e3f8043).

Files	Patch %	Lines
src/register/data/optimizelyExperiment/helper.js	13.04%	14 Missing and 6 partials ⚠️
src/register/RegistrationPage.jsx	66.66%	2 Missing ⚠️
...ent/useSimplifyRegistrationExperimentVariation.jsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1175      +/-   ##
==========================================
- Coverage   84.81%   84.23%   -0.58%     
==========================================
  Files         127      127              
  Lines        2371     2392      +21     
  Branches      671      678       +7     
==========================================
+ Hits         2011     2015       +4     
- Misses        345      357      +12     
- Partials       15       20       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zainab-amir]

For my understanding can you explain this condition? What is this doing?

[syedsajjadkazmii]

We have four states of experiment
1- (!expVariation) at start, when experiment is being initialized or not initialized because it was either embedded register page, tpaHint or currentProvider was available -> We want to show spinner when exp is being initialized and we want to show normal register page if its embedded register page, tpaHint or currentProvider is available.

2- (expVariation === NOT_INITIALIZED) experiment could not be initialized due to any unknown reason -> we want to show normal register page

3- (expVariation === DEFAULT_VARIATION) experiment is initialized and user is bucketed into the DEFAULT_VARIATION. -> we want to show normal register page

4- expVariation === SIMPLIFIED_REGISTRATION_VARIATION ) experiment is initialized and user is bucketed into the SIMPLIFIED_REGISTRATION_VARIATION . -> we want to show all fields except username on first step and username + honor_code in second step of simplified register page

[syedsajjadkazmii]

The above condition satisfies the above 4 scenarios