feat: add invalid form submit click event #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zainab-amir
reviewed
Mar 5, 2024
Comment on lines
36
to
39
| console.log(eventNames.simplifyRegistrationInvalidFormSubmitBtnClicked, { | ||
| variation: expVariation, | ||
| ...formErrors, | ||
| }); |
There was a problem hiding this comment.
Test code. Please remove
syedsajjadkazmii
force-pushed
the
sajjad/VAN-1827-add-errors-event
branch
from
579b51c to
1db73a6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1190 +/- ##
==========================================
- Coverage 84.27% 84.27% -0.01%
==========================================
Files 126 126
Lines 2385 2391 +6
Branches 677 679 +2
==========================================
+ Hits 2010 2015 +5
- Misses 355 356 +1
Partials 20 20 ☔ View full report in Codecov by Sentry. |
zainab-amir
approved these changes
Mar 5, 2024
syedsajjadkazmii
added a commit
to DmytroAlipov/frontend-app-authn
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding event on submit btn click on invalid form data. Simplified registration experiment
JIRA
VAN-1827
How Has This Been Tested?
Locally
Screenshots/sandbox (optional):
Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if its not applicable.
Merge Checklist
Post-merge Checklist