use useSelector with granular approach in registration component to minimize rendering #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mubbsharanwar
force-pushed
the
manwar/VAN-1890
branch
2 times, most recently
from
22bebd6 to
1400227
Compare
syedsajjadkazmii
suggested changes
Mar 27, 2024
mubbsharanwar
force-pushed
the
manwar/VAN-1890
branch
from
1400227 to
a619453
Compare
Yes, I tested it on success, failure, backend validations, username suggestions, SSO, state persists, etc cases. |
…t to minimize rendrening
mubbsharanwar
force-pushed
the
manwar/VAN-1890
branch
from
a619453 to
d65fb6b
Compare
syedsajjadkazmii
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we are optimizing the
registrationcomponent by using reducer state more granular which helps to minimize the component rendering on dependent state change along with following best practices.Docs: Selectors should be as granular as possible
Reference: https://react-redux.js.org/api/hooks
JIRA
VAN-1890
How Has This Been Tested?
Locally