feat: Add max value warning and disable the submit button #426

farhaanbukhsh · 2025-01-12T06:37:15Z

Based on: #402

~~Discussions: ~~

Dependencies: None

Screenshots: Always include screenshots if there is any change to the UI.

Sandbox URL: TBD - sandbox is being provisioned.

Merge deadline: "None" if there's no rush, "ASAP" if it's critical, or provide a specific date if there is one.

Testing instructions:

Mount the grade book repo in Tutor make sure Tutor is not running at this moment, tutor mounts add <repo-for-gradebook>
Rebuild the image tutor image build openedx-dev
tutor dev start -d
Import demo course tutor dev do importdemocourse
Make a learner account, enroll in the course and take a bunch of quiz, assignments
Log out and sign in from a super user account.
Under the Demo course, get into the "Student Admin" tab
There is "View gradebook for enrolled learners" section
Click on "View Gradebook"
You will see something like above
Click on marks and you should be able to give marks beyond 100% ie. something like 50/20
In Gradebook repo change to the PR branch
Restart gradebok tutor dev restart gradebook
Repeat Step 12 you will see an error and the input will be disabled.

openedx-webhooks · 2025-01-12T06:37:19Z

Thanks for the pull request, @farhaanbukhsh!

This repository is currently maintained by @farhaanbukhsh.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov · 2025-01-12T06:39:12Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.99%. Comparing base (e458d6f) to head (b063153).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
+ Coverage   94.98%   94.99%   +0.01%     
==========================================
  Files         139      139              
  Lines        1356     1359       +3     
  Branches      265      265              
==========================================
+ Hits         1288     1291       +3     
  Misses         60       60              
  Partials        8        8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: lkatsikaris <lkatsikaris@@users.noreply.github.com> Signed-off-by: Farhaan Bukhsh <[email protected]>

farhaanbukhsh · 2025-01-22T09:38:10Z

@bradenmacdonald @arbrandes Can you folks review this PR, please 😇

bradenmacdonald · 2025-01-23T22:25:15Z

@farhaanbukhsh Can you please provide test instructions, or get another reviewer to confirm that this is working? I don't even know how to access the gradebook, but am happy to help review if you provide the instructions (or a sandbox).

farhaanbukhsh · 2025-01-31T12:43:49Z

@farhaanbukhsh Can you please provide test instructions, or get another reviewer to confirm that this is working? I don't even know how to access the gradebook, but am happy to help review if you provide the instructions (or a sandbox).

Thanks a lot @bradenmacdonald

I don't have anyone but you and Adolfo to review the PRs so I'm sorry for troubling you. But it will really help to keep the repo up to date :)

bradenmacdonald · 2025-02-04T01:50:29Z

Click on marks and you should be able to give marks beyond 100% ie. something like 50/20

Are we sure this should be disallowed? My professors in University used to regularly give "bonus marks" and people sometimes got grades like 105% on various quizzes/exams.

bradenmacdonald

LGTM! I just had a product question ^ to confirm that we actually want to prevent this.

I tested and it's working as expected:

bradenmacdonald · 2025-02-04T02:07:04Z

src/components/GradesView/EditModal/OverrideTable/AdjustedGradeInput/index.jsx

        name="adjustedGradeValue"
        value={value}
        onChange={onChange}
      />
-      {hintText}
+      {value > possibleGrade ? <div style={{ color: 'red' }}>{ formatMessage(messages.adjustedGradeError, { possibleGrade })}</div> : hintText}


Nit: It's generally preferred to use the <FormattedMessage /> component rather than calling formatMessage directly.

farhaanbukhsh · 2025-02-04T14:09:13Z

Click on marks and you should be able to give marks beyond 100% ie. something like 50/20

Are we sure this should be disallowed? My professors in University used to regularly give "bonus marks" and people sometimes got grades like 105% on various quizzes/exams.

I have asked on the issue @bradenmacdonald but from the discussion, it looks like there have been enough talks around it but it's missing a formal product review.

mphilbrick211 · 2025-02-25T16:41:26Z

@bradenmacdonald @farhaanbukhsh is this all set to merge?

bradenmacdonald · 2025-02-25T18:23:31Z

I think so - @farhaanbukhsh can merge it anytime.

bradenmacdonald · 2025-02-25T18:24:44Z

Oh actually I mis-spoke: we asked about a product review and haven't heard anything back yet: #394 (comment)

farhaanbukhsh · 2025-02-26T09:26:40Z

@bradenmacdonald thank you for adding the link to the discussion and pointing it back. @mphilbrick211 I felt that this should be finalized first since Braden also pointed out that some instructors give more than 100% of the marks, I want to be sure that it's not a feature we are treating as a bug. :)

farhaanbukhsh requested a review from a team as a code owner January 12, 2025 06:37

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 12, 2025

feat: Add max value warning and disable the submit button

b063153

Co-authored-by: lkatsikaris <lkatsikaris@@users.noreply.github.com> Signed-off-by: Farhaan Bukhsh <[email protected]>

farhaanbukhsh force-pushed the farhaan/max-adjusted-grade-warning branch from ca61729 to b063153 Compare January 12, 2025 14:20

farhaanbukhsh mentioned this pull request Jan 22, 2025

fix: max adjusted grades warning and error #402

Closed

6 tasks

mariajgrimaldi mentioned this pull request Jan 23, 2025

Adjusted grades should not greater than 100% #394

Open

bradenmacdonald approved these changes Feb 4, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add max value warning and disable the submit button #426

feat: Add max value warning and disable the submit button #426

farhaanbukhsh commented Jan 12, 2025 •

edited

Loading

openedx-webhooks commented Jan 12, 2025 •

edited

Loading

codecov bot commented Jan 12, 2025 •

edited

Loading

farhaanbukhsh commented Jan 22, 2025

bradenmacdonald commented Jan 23, 2025

farhaanbukhsh commented Jan 31, 2025

bradenmacdonald commented Feb 4, 2025

bradenmacdonald left a comment

bradenmacdonald Feb 4, 2025

farhaanbukhsh commented Feb 4, 2025 •

edited

Loading

mphilbrick211 commented Feb 25, 2025

bradenmacdonald commented Feb 25, 2025

bradenmacdonald commented Feb 25, 2025

farhaanbukhsh commented Feb 26, 2025

feat: Add max value warning and disable the submit button #426

Are you sure you want to change the base?

feat: Add max value warning and disable the submit button #426

Conversation

farhaanbukhsh commented Jan 12, 2025 • edited Loading

openedx-webhooks commented Jan 12, 2025 • edited Loading

codecov bot commented Jan 12, 2025 • edited Loading

Codecov Report

farhaanbukhsh commented Jan 22, 2025

bradenmacdonald commented Jan 23, 2025

farhaanbukhsh commented Jan 31, 2025

bradenmacdonald commented Feb 4, 2025

bradenmacdonald left a comment

Choose a reason for hiding this comment

bradenmacdonald Feb 4, 2025

Choose a reason for hiding this comment

farhaanbukhsh commented Feb 4, 2025 • edited Loading

mphilbrick211 commented Feb 25, 2025

bradenmacdonald commented Feb 25, 2025

bradenmacdonald commented Feb 25, 2025

farhaanbukhsh commented Feb 26, 2025

farhaanbukhsh commented Jan 12, 2025 •

edited

Loading

openedx-webhooks commented Jan 12, 2025 •

edited

Loading

codecov bot commented Jan 12, 2025 •

edited

Loading

farhaanbukhsh commented Feb 4, 2025 •

edited

Loading