Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Don't clone State #11512

Closed
dvdplm opened this issue Feb 23, 2020 · 0 comments
Closed

Don't clone State #11512

dvdplm opened this issue Feb 23, 2020 · 0 comments
Labels
A3-stale 🍃 Pull request did not receive any updates in a long time. No review needed at this stage. Close it. F7-optimisation 💊 An enhancement to provide better overall performance in terms of time-to-completion for a task. P9-somedaymaybe 🌞 Issue might be worth doing eventually.

Comments

@dvdplm
Copy link
Collaborator

dvdplm commented Feb 23, 2020 •
edited
Loading

Sort out this TODO: "cloning for State shouldn't be possible in general; Remove this and use checkpoints where possible.".

It was added in #4632, other related PRs:

I assume that using checkpoints instead of Clones is more efficient, since we only store the diff.
We still use clones here https://github.com/paritytech/parity-ethereum/blob/856a0755888a30d4dc52a68cb2638a8bfd5786ac/ethcore/src/block.rs#L239
@dvdplm dvdplm mentioned this issue Feb 23, 2020
Merged
@niklasad1 niklasad1 added F7-optimisation 💊 An enhancement to provide better overall performance in terms of time-to-completion for a task. P9-somedaymaybe 🌞 Issue might be worth doing eventually. labels Feb 26, 2020
@adria0 adria0 added the A3-stale 🍃 Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Jul 27, 2020
@adria0 adria0 closed this as completed Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A3-stale 🍃 Pull request did not receive any updates in a long time. No review needed at this stage. Close it. F7-optimisation 💊 An enhancement to provide better overall performance in terms of time-to-completion for a task. P9-somedaymaybe 🌞 Issue might be worth doing eventually.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dvdplm @adria0 @niklasad1