Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Timestamp in new keys' filename #1694

Closed
gavofyork opened this issue Jul 23, 2016 · 2 comments
Closed

Timestamp in new keys' filename #1694

gavofyork opened this issue Jul 23, 2016 · 2 comments
Assignees
Labels
F8-enhancement 🎊 An additional feature request.
Milestone

Comments

@gavofyork
Copy link
Contributor

The filename of newly created keys should include a timestamp. Consider also placing the timestamp in the metadata.

@gavofyork gavofyork added the F8-enhancement 🎊 An additional feature request. label Jul 23, 2016
@gavofyork gavofyork added this to the 1.3 Acuity milestone Jul 23, 2016
@gavofyork gavofyork self-assigned this Jul 23, 2016
@gavofyork
Copy link
Contributor Author

Fixed in #1700.

@A2be
Copy link

A2be commented Jul 23, 2016

It a bit hard for me to tell the specifics of what you did here. Looks like date is included, but what format, etc.?

In my view, best would be to

  1. have Parity exactly match the keystore filename used in the de facto standard geth (largest adoption as of early July 2016), and to
  2. also update the (de jure?) web3 spec at https://github.com/ethereum/wiki/wiki/Web3-Secret-Storage-Definition so that all implementations of Ethereum Node software might be encouraged to use a similar (or identical) keystore naming standard for their keystore files.

Rationale : better UX for the uncommon, but not rare, occurrence where humans are actually looking at their keystore keys manually in a file manager, and the keys of various accounts were created by different Ethereum Node programs. In short, better for the Ethereum ecosphere long term to make user experience easier with long-forgotten keys stored on various odd digital storage devices.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F8-enhancement 🎊 An additional feature request.
Projects
None yet
Development

No branches or pull requests

2 participants