Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

refactor signer components #2687

Closed
derhuerst opened this issue Oct 18, 2016 · 0 comments
Closed

refactor signer components #2687

derhuerst opened this issue Oct 18, 2016 · 0 comments
Labels
A0-pleasereview 🤓 Pull request needs code review. F6-refactor 📚 Code needs refactoring.

Comments

@derhuerst
Copy link
Contributor

derhuerst commented Oct 18, 2016 •
edited
Loading

The signer is a mess right now.

  • remove Web3 stuff
  • remove duplicate code of TransactionPending and TransactionFinished

Once this is done, it will be easier to implement #2688 and #2686.
@derhuerst derhuerst added M5-ui F6-refactor 📚 Code needs refactoring. labels Oct 18, 2016
@derhuerst derhuerst self-assigned this Oct 18, 2016
@derhuerst derhuerst mentioned this issue Oct 18, 2016
Merged
@derhuerst derhuerst removed their assignment Oct 18, 2016
@derhuerst derhuerst added the A0-pleasereview 🤓 Pull request needs code review. label Oct 18, 2016
@jacogr jacogr closed this as completed Oct 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A0-pleasereview 🤓 Pull request needs code review. F6-refactor 📚 Code needs refactoring.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacogr @derhuerst