Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Copy button missing at contract creation #3134

Closed
chevdor opened this issue Nov 3, 2016 · 5 comments
Closed

Copy button missing at contract creation #3134

chevdor opened this issue Nov 3, 2016 · 5 comments
Assignees
Labels
P7-nicetohave 🐕 Issue is worth doing eventually. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.

Comments

@chevdor
Copy link

chevdor commented Nov 3, 2016

I know there are big changes in progress on the topic so this will likely fixed in an existing PR but I keep it separated to handle it easier.

During the contract creation, if a contract ctor requires an address, the address input field does not seem to be the one that is being worked on at the moment by @derhuerst. The current control does not list the accounts, we can only type an address in.

Also when the contract has been deployed, its address is displayed but without a "copy to clipboard" button, that would be rather convenient there.

@jacogr jacogr added Z0-unconfirmed 🤔 Issue might be valid, but it’s not yet known. M6-ui labels Nov 3, 2016
@jacogr jacogr changed the title UI: Copy button missing at contract creation Copy button missing at contract creation Nov 3, 2016
@jacogr
Copy link
Contributor

jacogr commented Nov 3, 2016

  1. Not sure this is valid - checked both contract execution & contract creation modals, both use the InputAddressSelect components. (Which basically allows for either manual inputs of selecting from a list.)
  2. Copy is available when the contract was added to the list, can't hurt having it there, but nice-to-have atm.

@jacogr jacogr added the F8-enhancement 🎊 An additional feature request. label Nov 3, 2016
@chevdor
Copy link
Author

chevdor commented Nov 3, 2016

Ok, I checked again. I think it IS the new component indeed. I was just surprised by the fact that (at least in the version I have), you no longer get a full list when clicking the input field. It seems now to be mandatory to type something in :(

The second 'issue' is there but I agree this should be low prio or even postponed after 1.4
screen_shot_2016-11-03_at_17_37_01

@jacogr
Copy link
Contributor

jacogr commented Nov 3, 2016

Yes, type to search :( However when I click on my field it does pop up the list. What happens when you Transfer - the recipient is the same component, does that one open when clicked?

@chevdor
Copy link
Author

chevdor commented Nov 3, 2016

I currently cannot say. See #3146

@chevdor
Copy link
Author

chevdor commented Nov 3, 2016

I could see it in Contract/Execute as well as in Contract/Deploy. So the listing of account is back on track. The only remaining would be to have this copy button to copy the address of created contracts. It should be no brainer since the new address input component as now a readOnly mode.

This is used already in the events:
screen shot 2016-11-03 at 18 31 37

Users can copy, select, not edit, see the identityicon... rather perfect!

@jacogr jacogr added P7-nicetohave 🐕 Issue is worth doing eventually. P5-sometimesoon 🌲 Issue is worth doing soon. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow. and removed F8-enhancement 🎊 An additional feature request. Z0-unconfirmed 🤔 Issue might be valid, but it’s not yet known. P5-sometimesoon 🌲 Issue is worth doing soon. labels Nov 3, 2016
@jacogr jacogr self-assigned this Nov 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P7-nicetohave 🐕 Issue is worth doing eventually. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Projects
None yet
Development

No branches or pull requests

2 participants