Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

RPC API should return transaction "v", "r", "s" values #3158

Closed
fjl opened this issue Nov 3, 2016 · 4 comments
Closed

RPC API should return transaction "v", "r", "s" values #3158

fjl opened this issue Nov 3, 2016 · 4 comments
Assignees
Labels
F8-enhancement 🎊 An additional feature request. M4-core ⛓ Core client code / Rust. P5-sometimesoon 🌲 Issue is worth doing soon. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.

Comments

@fjl
Copy link

fjl commented Nov 3, 2016

Please return these values because they make reconstructing complete transactions possible on the client side. Geth will start returning these in v1.5.

@tomusdrw tomusdrw added F8-enhancement 🎊 An additional feature request. P5-sometimesoon 🌲 Issue is worth doing soon. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow. M4-core ⛓ Core client code / Rust. labels Nov 4, 2016
@tomusdrw tomusdrw self-assigned this Nov 4, 2016
@stevenroose
Copy link

stevenroose commented Nov 15, 2016

Version Parity//v1.4.3-beta-08a4220-20161114/x86_64-linux-gnu/rustc1.13.0 (current latest Docker beta-release), which should include #3172 does still make ethclient throw an missing required JSON transaction signature fields error:
https://github.com/ethereum/go-ethereum/blob/b10bcd924ba79f9faa5b8f2d273a7ee02d7b89f5/core/types/transaction.go#L196

So this issue is somehow not yet resolved.

(Reported in go-ethereum as well.)

@tomusdrw
Copy link
Collaborator

My bad, seems that I forgot to mark the PR to be backported to beta branch. Made additional PR now.

@stevenroose
Copy link

Thanks!

@tjayrush
Copy link

I summarized seven differences between 'geth' and Parity and the documentation in this issue: https://github.com/ethcore/parity/issues/3601. I did tests against about 1,000 randomly selected blocks and found only the noted differences.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F8-enhancement 🎊 An additional feature request. M4-core ⛓ Core client code / Rust. P5-sometimesoon 🌲 Issue is worth doing soon. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Projects
None yet
Development

No branches or pull requests

4 participants