-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Multi-sig contract does not send any amount on Ethereum Classic #4057
Comments
@ngotchac Seems ETH contract code not working correctly under ETC for some reason? |
@SyRenity It seems that a lot of transactions have failed due to gas estimation issues (eg. http://gastracker.io/tx/0x41720e414e29b63916656facdb2813f0abc14ca05d9610c84d6ab5f1db7103bb) Could you try to resend those transactions increasing the supplied gas amount (from the Edit Gas button in the signer, before signing the transaction). Gas estimation might sometime be a little off... |
@ngotchac The transactions indeed failed until I've manually increased to a quite large value, and then they went through for remaining 2 co-signers. The contract unfortunately never performed any sending afterwards (compared to the Eth one). |
@SyRenity It seems that the created transaction (http://gastracker.io/tx/0x186d0790809ebca2a12b89e924ed87b0527654d45160ba45f86119f4dfdf4360) had the wrong input, because it tried to send |
@ngotchac Sure, should I redeploy a new multi-sig contract as well? |
I don't think so, you shouldn't have to at least |
@ngotchac Tried this again, unfortunately it didn't work: You can see that the transactions went fine, but the contract was stll not executed. So, would it be a good idea to redploy? |
Something is wrong on our side on how we convert the user input to actually token/wei value. A PR is out (#4098) that would maybe fix that. If not, some logging info will be available for an easier debug... |
@ngotchac Will specifying higher gas limit help with that? I tried up to 999999 with the same result. |
No, unfortunately the issue is that the UI creates a transaction with the wrong info (the amount has too many zeros basically) |
@SyRenity You should be able to try again, after having built window.localStorage.setItem('loglevel:modals/Transfer/store', 'TRACE'); This will add more logging/debugging. Then try again from scratch to send some eth, and share the logs printed in the console, that would help greatly ! |
@ngotchac Just to be on same page, we speak about ETC (ETH works just fine). |
Ok so I just tried with ETC, and everything works fine on my end... So I would suggest to try to again with the extras logging enabled as described above (will only work on latest master), and share those logs.... |
@ngotchac In the latest master the transaction never sent (despite setting a high gas of 999999), the UI shows the error "the transaction will throw an exception with the current values", and the console logs the following errors:
|
@ngotchac Confirmed, ETC sending works fine now :). |
Great, thanks for taking the time to test !! |
After the UI problem has been fixed, I tested the multi-sig sending both on ETH and on ETC.
On ETH it works fine, on ETC the contract doesn't actually send anything, despite being signed by minimum amount of co-signers, and the sign request disappearing from Parity UI.
http://gastracker.io/addr/0x677c0cca27b705b59d13a6ffd419bec3ef0a8cd8
The text was updated successfully, but these errors were encountered: