Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Unify debug/display for Address/Public/Secret #6206

Closed
debris opened this issue Aug 1, 2017 · 3 comments · Fixed by #8076
Closed

Unify debug/display for Address/Public/Secret #6206

debris opened this issue Aug 1, 2017 · 3 comments · Fixed by #8076
Assignees
Labels
F6-refactor 📚 Code needs refactoring. M4-core ⛓ Core client code / Rust. P7-nicetohave 🐕 Issue is worth doing eventually. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.

Comments

@debris
Copy link
Collaborator

debris commented Aug 1, 2017

#6187 (comment)

@debris debris added M4-core ⛓ Core client code / Rust. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow. labels Aug 1, 2017
@5chdn 5chdn added P7-nicetohave 🐕 Issue is worth doing eventually. F6-refactor 📚 Code needs refactoring. and removed P7-nicetohave 🐕 Issue is worth doing eventually. labels Sep 5, 2017
@5chdn 5chdn added this to the 1.10 & ... milestone Oct 5, 2017
@jvalleroy
Copy link

@debris Would you expect address/public to be displayed in abbreviated form like c4c5…fcf4? That's due to the display function implementation for the bigint.hash types.

@debris
Copy link
Collaborator Author

debris commented Oct 13, 2017

sry for late response.

it would be perfect if we could get something like this:

  • debug equal to [derive(Debug)]
  • display in form of c4c5…fcf4
  • display with alternate flag displaying the whole hash

but to be honest, it doesn't matter to me how it is displayed as long as it is consistent ;)

take a look at this snippet:

https://github.com/paritytech/parity/blob/eecd823d32b3f4d88f64a6c41acec9c2b0b78994/ethkey/cli/src/main.rs#L170-L177

it would be good if we could unify this

@kirushik
Copy link
Collaborator

@jvalleroy Hi!
I guess you're trying to participate in Hacktoberfest with this issue, right?
What's your current status with it? Do you need any help in finalizing your work?

Please keep in mind that only PRs submitted in October (which ends tomorrow) qualify for Hacktoberfest.

@5chdn 5chdn modified the milestones: 1.10, 1.11 Jan 23, 2018
@5chdn 5chdn modified the milestones: 1.11, 1.12 Mar 1, 2018
@niklasad1 niklasad1 self-assigned this Mar 8, 2018
@5chdn 5chdn modified the milestones: 1.12, 1.11 Mar 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F6-refactor 📚 Code needs refactoring. M4-core ⛓ Core client code / Rust. P7-nicetohave 🐕 Issue is worth doing eventually. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants