Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Token Registry lookups cause 1000's of eth_calls if you have multiple accounts #6387

Closed
5chdn opened this issue Aug 26, 2017 · 5 comments
Closed

Token Registry lookups cause 1000's of eth_calls if you have multiple accounts #6387

5chdn opened this issue Aug 26, 2017 · 5 comments
Assignees
@tomusdrw
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. F7-footprint 🐾 An enhancement to provide a smaller (system load, memory, network or disk) footprint. M8-dapp 💎 Decentralized applications. P0-dropeverything 🌋 Everyone should address the issue now.

Comments

@5chdn
Copy link
Contributor

5chdn commented Aug 26, 2017

Before filing a new issue, please provide the following information.

I'm running:

  • Parity version: 1.7.0
  • Operating system: Linux
  • And installed: binaries

Your issue description goes here below. Try to include actual vs. expected behavior and steps to reproduce the issue.

Token Registry lookups cause 1000's of eth_calls if you have multiple accounts. Token registry currently has more than 300 entries. They are queried for each account you have and cause the RPC to not being able to catch up. The UI becomes very slow.
@5chdn 5chdn added F2-bug 🐞 The client fails to follow expected behavior. M8-dapp 💎 Decentralized applications. M7-ui labels Aug 26, 2017
@5chdn 5chdn mentioned this issue Aug 26, 2017
Closed
@5chdn 5chdn added F7-footprint 🐾 An enhancement to provide a smaller (system load, memory, network or disk) footprint. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. and removed F2-bug 🐞 The client fails to follow expected behavior. labels Aug 26, 2017
@debris
Copy link
Collaborator

debris commented Aug 26, 2017

So the problem is caused by each call creating a new state copy. afaik @tomusdrw recently addressed this issue by added parity_call rpc method which reuses a single state copy for multiple calls. Our ui should use this method and check all balances together

@5chdn
Copy link
Contributor Author

5chdn commented Aug 28, 2017

Just looking at the logs: it's currently around 100-thousand RPC requests per minute.

@5chdn 5chdn mentioned this issue Aug 28, 2017
Closed
@tomusdrw tomusdrw self-assigned this Aug 28, 2017
This was referenced Aug 29, 2017
Closed
Closed
Closed
Closed
Closed
@5chdn 5chdn added P0-dropeverything 🌋 Everyone should address the issue now. and removed P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. labels Aug 31, 2017
@5chdn 5chdn added the F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. label Sep 4, 2017
@5chdn 5chdn mentioned this issue Sep 11, 2017
Closed
@5chdn
Copy link
Contributor Author

5chdn commented Sep 11, 2017

#6471 closes this, does it?

@tomusdrw
Copy link
Collaborator

Indeed.

@5chdn
Copy link
Contributor Author

5chdn commented Sep 11, 2017

🎉

@5chdn 5chdn mentioned this issue Sep 12, 2017
Closed
@tomusdrw tomusdrw mentioned this issue Sep 17, 2017
Closed
@dev-dan dev-dan mentioned this issue Oct 7, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tomusdrw tomusdrw

Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. F7-footprint 🐾 An enhancement to provide a smaller (system load, memory, network or disk) footprint. M8-dapp 💎 Decentralized applications. P0-dropeverything 🌋 Everyone should address the issue now.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tomusdrw @debris @5chdn