Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Test eth RPC interface for the light client. #8693

Closed
dvdplm opened this issue May 23, 2018 · 2 comments
Closed

Test eth RPC interface for the light client. #8693

dvdplm opened this issue May 23, 2018 · 2 comments
Labels
F4-tests 💻 Tests need fixing, improving or augmenting. M4-core ⛓ Core client code / Rust. P5-sometimesoon 🌲 Issue is worth doing soon.
Milestone

Comments

@dvdplm
Copy link
Collaborator

dvdplm commented May 23, 2018

Currently there are no tests for RPC calls against the light client and there is a significant amount of logic to manage requests.
The tests for the full client require a fair amount of setup and the difference in style of implementation means that replicating that for the light client RPC calls could be a significant chunk of work.

Can/should some of this logic be moved from the rpc crate into ethcore/light? It is possible that using the existing testing helpers in ethcore/light will make it easier to achieve proper test coverage.

The background to this issue is a panic-bug that was caused by an off-by-one mistake in the rpc crate when setting up requests for an eth_getBlockByHash RPC call: finding the bug was harder than expected and adding a test for it even more so (hence this ticket here).

@dvdplm dvdplm added F4-tests 💻 Tests need fixing, improving or augmenting. P5-sometimesoon 🌲 Issue is worth doing soon. M4-core ⛓ Core client code / Rust. labels May 23, 2018
@rphmeier
Copy link
Contributor

We should be able to mock the OnDemand service completely for the light client RPCs. IMO that would work better than actually trying to set up a dummy network to request data from.

@5chdn 5chdn added this to the 1.12 milestone Jun 13, 2018
@5chdn 5chdn modified the milestones: 2.0, 2.1 Jul 17, 2018
@5chdn 5chdn modified the milestones: 2.1, 2.2 Sep 11, 2018
@5chdn 5chdn modified the milestones: 2.2, 2.3 Oct 29, 2018
@5chdn 5chdn modified the milestones: 2.3, 2.4 Jan 10, 2019
@niklasad1 niklasad1 self-assigned this Jan 29, 2019
@5chdn 5chdn modified the milestones: 2.4, 2.5 Feb 21, 2019
@soc1c soc1c modified the milestones: 2.5, 2.6 Apr 2, 2019
@niklasad1 niklasad1 removed their assignment May 25, 2019
@ordian ordian modified the milestones: 2.6, 2.7 Jul 12, 2019
@adria0
Copy link

adria0 commented Jul 27, 2020

Closing issue due to its stale state.

@adria0 adria0 closed this as completed Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F4-tests 💻 Tests need fixing, improving or augmenting. M4-core ⛓ Core client code / Rust. P5-sometimesoon 🌲 Issue is worth doing soon.
Projects
None yet
Development

No branches or pull requests

7 participants