This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Test eth RPC interface for the light client. #8693
Labels
F4-tests 💻
Tests need fixing, improving or augmenting.
M4-core ⛓
Core client code / Rust.
P5-sometimesoon 🌲
Issue is worth doing soon.
Milestone
Currently there are no tests for RPC calls against the light client and there is a significant amount of logic to manage requests.
The tests for the full client require a fair amount of setup and the difference in style of implementation means that replicating that for the light client RPC calls could be a significant chunk of work.
Can/should some of this logic be moved from the rpc crate into
ethcore/light
? It is possible that using the existing testing helpers inethcore/light
will make it easier to achieve proper test coverage.The background to this issue is a panic-bug that was caused by an off-by-one mistake in the rpc crate when setting up requests for an
eth_getBlockByHash
RPC call: finding the bug was harder than expected and adding a test for it even more so (hence this ticket here).The text was updated successfully, but these errors were encountered: