feat: user can select a facet value eg category which is not yet displayed - fixes #125 #134

Kout95 · 2024-06-05T18:05:03Z

What

user can select a facet value eg category which is not yet displayed

Screenshot

Fix

Fix Checkbox behaviour

Part of

User can select a facet value (eg category) which is not (yet) displayed #125

alexgarel

@Kout95, first thanks for this great PR.

Sorry I don't have the time to really review right know. I did a small test and found some problems.

frontend/src/search-facets.ts

frontend/src/search-autocomplete.ts

alexgarel

@Kout95, I leave my code review here for now, because I would like to have far more documentation (sorry but I find it painful to read as is).

At least document each method that is more than 3 lines long, always with the what (very short) and the why.

Thank you.

frontend/src/mixins/debounce.ts

frontend/src/mixins/search-action.ts

frontend/src/mixins/utils.ts

frontend/src/search-autocomplete.ts

alexgarel

Thanks for the great work and refactoring.

Still some suggestions to accpet and some issues to fix.

alexgarel · 2024-06-11T11:24:07Z

frontend/src/mixins/debounce.ts

+ * A mixin class for debouncing function calls.
+ * It extends the LitElement class and adds debouncing functionality.
+ * It is used to prevent a function from being called multiple times in a short period of time.
+ * It is usefull to avoid multiple calls to a function when the user is typing in an input field.


Great comment :-)

frontend/src/mixins/taxonomies-ctl.ts

frontend/src/search-facets.ts

frontend/src/mixins/taxonomies-ctl.ts

frontend/src/search-facets.ts

frontend/src/search-checkbox.ts

frontend/src/search-autocomplete.ts

Co-authored-by: Alex Garel <[email protected]>

…to correspond to mock

alexgarel

Thank you @Kout95, let's merge !

alexgarel · 2024-06-12T12:53:14Z

frontend/src/icons/cross.ts

alexgarel · 2024-06-12T12:56:12Z

frontend/src/utils/enums.ts

Thanks for moving.

Kout95 linked an issue Jun 5, 2024 that may be closed by this pull request

User can select a facet value (eg category) which is not (yet) displayed #125

Closed

github-actions bot assigned Kout95 Jun 5, 2024

teolemon changed the title ~~125 user can select a facet value eg category which is not yet displayed~~ fixes #125: user can select a facet value eg category which is not yet displayed Jun 5, 2024

teolemon changed the title ~~fixes #125: user can select a facet value eg category which is not yet displayed~~ feat: user can select a facet value eg category which is not yet displayed - fixes #125 Jun 5, 2024

teolemon added ✨ enhancement New feature or request side panel labels Jun 5, 2024

Kout95 force-pushed the 125-user-can-select-a-facet-value-eg-category-which-is-not-yet-displayed branch 2 times, most recently from 80d0deb to 2dbc6ea Compare June 6, 2024 18:32

Kout95 requested a review from alexgarel June 7, 2024 10:14

Kout95 marked this pull request as ready for review June 7, 2024 10:14

Kout95 force-pushed the 125-user-can-select-a-facet-value-eg-category-which-is-not-yet-displayed branch from be854c2 to 8319f42 Compare June 7, 2024 10:18

alexgarel reviewed Jun 7, 2024

View reviewed changes

frontend/src/search-facets.ts Outdated Show resolved Hide resolved

frontend/src/search-autocomplete.ts Outdated Show resolved Hide resolved

frontend/src/search-autocomplete.ts Show resolved Hide resolved

Kout95 force-pushed the 125-user-can-select-a-facet-value-eg-category-which-is-not-yet-displayed branch 2 times, most recently from 82e60c4 to be33d4f Compare June 8, 2024 08:40

Kout95 requested a review from alexgarel June 10, 2024 08:25

alexgarel requested changes Jun 10, 2024

View reviewed changes

Kout95 force-pushed the 125-user-can-select-a-facet-value-eg-category-which-is-not-yet-displayed branch from 01d26ac to 3c732d4 Compare June 11, 2024 07:17

Kout95 requested a review from alexgarel June 11, 2024 08:01

Kout95 force-pushed the 125-user-can-select-a-facet-value-eg-category-which-is-not-yet-displayed branch from 8980e2d to a0a8174 Compare June 11, 2024 08:31

alexgarel requested changes Jun 11, 2024

View reviewed changes

Kout95 added 10 commits June 12, 2024 10:40

feat: add autocomplete and start to search facet

42d016f

fix

105c424

fix: lint and move mixins to /mixins

d3d533f

fix: bind this to debounce fn

79f4400

feat: link autocomplete data

754b07e

fix: checkbox

667aa3e

feat: add showOther property

6c00f40

feat: add global reset-button.ts

3364a3d

fix

570a9da

fix: show other only in some facet and fix checkbox

7c03773

Kout95 and others added 14 commits June 12, 2024 10:40

Update frontend/src/search-autocomplete.ts

0f2e7bf

Co-authored-by: Alex Garel <[email protected]>

Update frontend/src/mixins/taxonomies-ctl.ts

418c6f8

Co-authored-by: Alex Garel <[email protected]>

Update frontend/src/mixins/taxonomies-ctl.ts

a5921fe

Co-authored-by: Alex Garel <[email protected]>

Update frontend/src/search-facets.ts

1dc2ab4

Co-authored-by: Alex Garel <[email protected]>

Update frontend/src/search-checkbox.ts

1fe348b

Co-authored-by: Alex Garel <[email protected]>

Update frontend/src/mixins/taxonomies-ctl.ts

635660b

Co-authored-by: Alex Garel <[email protected]>

refacto: fix vars and rename file

cfeaa1e

feat: add part

c35b301

feat: add comments

3c674ca

feat: add comments

84bc534

feat: add comments

8aeb289

feat: add comments

61d49f2

feat: add comments

ba0212e

Apply suggestions from code review

9ed4e4b

Co-authored-by: Alex Garel <[email protected]>

Kout95 force-pushed the 125-user-can-select-a-facet-value-eg-category-which-is-not-yet-displayed branch from 626f7cb to 9ed4e4b Compare June 12, 2024 08:40

Kout95 added 3 commits June 12, 2024 10:42

fix: lint

403cec7

fix: add enum

40def3a

feat: clean code, modify reset button in facet, update reset filters …

46b7d0e

…to correspond to mock

Kout95 requested a review from alexgarel June 12, 2024 11:55

Kout95 added 3 commits June 12, 2024 13:56

feat: add margin top to fieldset

b5a0bee

docs

bfc0dc2

docs

67c6fc7

Kout95 force-pushed the 125-user-can-select-a-facet-value-eg-category-which-is-not-yet-displayed branch from bfc0dc2 to 67c6fc7 Compare June 12, 2024 12:00

Kout95 added 2 commits June 12, 2024 14:06

refacto button-transparent

8cf0a9b

fix

5eebce0

alexgarel mentioned this pull request Jun 12, 2024

Handle the case of multiple concurrent requests, with API being slow (higher response time than debounce wait time) in suggestions #159

Closed

alexgarel approved these changes Jun 12, 2024

View reviewed changes

alexgarel merged commit 10bc65d into main Jun 12, 2024
6 checks passed

alexgarel deleted the 125-user-can-select-a-facet-value-eg-category-which-is-not-yet-displayed branch June 12, 2024 14:06

openfoodfacts-bot mentioned this pull request Jun 11, 2024

chore(main): release 1.3.0 #104

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: user can select a facet value eg category which is not yet displayed - fixes #125 #134

feat: user can select a facet value eg category which is not yet displayed - fixes #125 #134

Kout95 commented Jun 5, 2024 •

edited

Loading

alexgarel left a comment

alexgarel left a comment

alexgarel left a comment

alexgarel Jun 11, 2024

alexgarel left a comment

alexgarel Jun 12, 2024

alexgarel Jun 12, 2024

feat: user can select a facet value eg category which is not yet displayed - fixes #125 #134

feat: user can select a facet value eg category which is not yet displayed - fixes #125 #134

Conversation

Kout95 commented Jun 5, 2024 • edited Loading

What

Screenshot

Fix

Part of

alexgarel left a comment

Choose a reason for hiding this comment

alexgarel left a comment

Choose a reason for hiding this comment

alexgarel left a comment

Choose a reason for hiding this comment

alexgarel Jun 11, 2024

Choose a reason for hiding this comment

alexgarel left a comment

Choose a reason for hiding this comment

alexgarel Jun 12, 2024

Choose a reason for hiding this comment

alexgarel Jun 12, 2024

Choose a reason for hiding this comment

Kout95 commented Jun 5, 2024 •

edited

Loading