feat: add search params in url #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kout95
force-pushed
the
126-add-the-possibliity-to-launch-search-on-launch
branch
from
b4eb889 to
f43e759
Compare
alexgarel
requested changes
Jun 11, 2024
There was a problem hiding this comment.
Thanks for the work @Kout95
-
Can we eventually split the history / params methods in a different file to avoid cluttering too much the search-bar. (at least the one doing transformations)
-
the prefix is not a constant but the search-bar name property
-
triggering first search should be done in a more reliable way
Kout95
force-pushed
the
126-add-the-possibliity-to-launch-search-on-launch
branch
from
81a626d to
0a51cb9
Compare
Kout95
force-pushed
the
126-add-the-possibliity-to-launch-search-on-launch
branch
from
e5c7f28 to
7d053cc
Compare
alexgarel
reviewed
Jun 17, 2024
Kout95
force-pushed
the
126-add-the-possibliity-to-launch-search-on-launch
branch
from
bd845b7 to
1d6647c
Compare
Co-authored-by: Alex Garel <[email protected]>
…rectly in constructor
Co-authored-by: Alex Garel <[email protected]>
Kout95
force-pushed
the
126-add-the-possibliity-to-launch-search-on-launch
branch
from
1d6647c to
d7a3a9b
Compare
alexgarel
reviewed
Jun 18, 2024
Comment on lines
+14
to
+25
| export type SearchaliciousHistoryInterface = { | ||
| query: string; | ||
| name: string; | ||
| _currentPage?: number; | ||
| _facetsNodes: () => SearchaliciousFacets[]; | ||
| _facetsFilters: () => string; | ||
| convertHistoryParamsToValues: (params: URLSearchParams) => HistoryOutput; | ||
| setValuesFromHistory: (values: HistoryOutput) => void; | ||
| buildHistoryParams: (params: BuildParamsOutput) => HistoryParams; | ||
| setParamFromUrl: () => {launchSearch: boolean; values: HistoryOutput}; | ||
| }; | ||
|
|
There was a problem hiding this comment.
I will add myself a commit to put it in another file, because I find it strange to have it defined here. (but I take on me).
There was a problem hiding this comment.
Hum, it's more complicated than it seems indeed, so I wont do that now !
Thanks however for separating history code…
This was referenced Jun 19, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
q=Part of