feat: implement scores distributions charts #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feat-implement-charts-123
alexgarel
reviewed
Jun 12, 2024
There was a problem hiding this comment.
Thanks for this work @Marc-AntoineA
I think we should talk about it in a small meeting to decide next steps.
and add some doc
* fix: override updated function (and create a vegaRepresentation object) * feat: raise error if vega does not exist ; * lint: add typescript types and deactivate "no-ts-ignore" rule
… feat-implement-charts-123
alexgarel
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
@Marc-AntoineA it's ready to merge for me.
I added two comment, it's up to you to decide if you do it in a new PR or in this PR, but try not to loose the information :-)
frontend/src/search-chart.ts
Outdated
Comment on lines
33
to
44
| try { | ||
| vega; | ||
| } catch (e) { | ||
| if (e instanceof ReferenceError) { | ||
| console.error( | ||
| 'Vega is required to use searchalicious-chart, you can import it using \ | ||
| <script src="https://cdn.jsdelivr.net/npm/vega@5"></script>' | ||
| ); | ||
| return html`<p>Please install vega to use searchalicious-chart</p>`; | ||
| } | ||
| throw e; | ||
| } |
There was a problem hiding this comment.
Instead of testing it every time, I would do this in firstUpdated:
// eslint-disable-next-line @typescript-eslint/no-explicit-any
override firstUpdated(changedProperties: Map<any, any>) {
super.firstUpdated(changedProperties);
this.testVegaExists();
}There was a problem hiding this comment.
I set a boolean vegaInstalled in the constructor
* do not check vega everytime * use slot to allow "no-data" message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Create small vega histograms for current results nova, eco and nutri-score distributions.
Screenshot
Fixes bug(s)
#123
Part of