feat: search bar component #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valimp
reviewed
Apr 15, 2024
Comment on lines
+60
to
+67
| @state() | ||
| _pageCount?: Number; | ||
|
|
||
| @state() | ||
| _results?: {}[]; | ||
|
|
||
| @state() | ||
| _count?: Number; |
There was a problem hiding this comment.
Is it usefull to comment states like you do for property ?
There was a problem hiding this comment.
Good point, I'll add them on next PR.
Comment on lines
+140
to
+141
| const response = await fetch(this._searchUrl()); | ||
| const data = await response.json(); |
There was a problem hiding this comment.
I don't understand why this is in two lines
There was a problem hiding this comment.
just for readability ! How would you write it ?
There was a problem hiding this comment.
I didn't understand why the two "await" were necessary.
I just got it 👍🏼
|
Merging, as it's work in progress, not displayed yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work on the search-bar component
we have a search box and a button. It can be tested locally on http://search.localhost:8000/static/off.html.
At the moment it just send the request, it does not display the results (next results components).