-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] dependency cli-color
has licensing issues
#56
Comments
Hi @DerekNonGeneric, I posted a PR for this ussue, but I'm having some problems with some of the tests required by your repo: I'd think that this file, being automatically generated, should be excluded from these tests, but if you'd like, I'd be more than happy to apply some changes to it |
Hi @dadolhay, thanks; that would be cool by me. If you prefer, you can also exclude the out-generated file from your changes. |
I made two changes:
With this it seems all tests are passing, but please note, that the functionality of |
Yeah, thanks! Noted; that would need to be taken care of in a separate PR. The issue for it is #115. :) |
Fixes: #56 Signed-off-by: Denes Dolhay <[email protected]> Signed-off-by: Derek Lewis <[email protected]> Co-authored-by: Denes Dolhay <[email protected]> Co-authored-by: Derek Lewis <[email protected]>
According to Socket,
cli-color
has issues related to licensing. We are currently using the MIT license for the packages we publish on npm and intend to continue doing so. This is kind of a hard requirement since a lot of projects have a strict requirement of having an MIT license. It is also important that the dependencies of our dependencies are MIT licensed as well.We may be able to swap this one out for
colorette
, which is MIT-licensed (silver quality) and maintained by my good friend @jorgebucaran. It has no dependencies.Refs: DerekNonGeneric/loader339#11 (comment)
The text was updated successfully, but these errors were encountered: