fix(deps): replace cli-color dep with colorette #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
Signed-off-by: Denes Dolhay <[email protected]>
ghost
changed the title
Signed-off-by: Denes Dolhay <[email protected]>
Signed-off-by: Derek Lewis <[email protected]>
Signed-off-by: Denes Dolhay <[email protected]>
Signed-off-by: Denes Dolhay <[email protected]>
Signed-off-by: Derek Lewis <[email protected]>
DerekNonGeneric
approved these changes
Oct 14, 2022
There was a problem hiding this comment.
Looks good to me! I wonder if @jorgebucaran thinks so too. :)
Signed-off-by: Denes Dolhay <[email protected]>
|
@DerekNonGeneric it seems, that it does not agree with your change about the import. What do you want me to do? leave it as is, and you'll ignore the warning, or rewrite all imports to double quotes so it's consistent and passes the test? |
jorgebucaran
approved these changes
Oct 14, 2022
Yeah, that's what we'll do here; apparently it needs to be reconfigured — not a problem! |
DerekNonGeneric
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR do?
cli-colordependency withcolorettecloses #56