Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Make SH and PH evaluation optional #463

Open
naerymdan opened this issue Apr 4, 2024 · 0 comments
Open

[Suggestion] Make SH and PH evaluation optional #463

naerymdan opened this issue Apr 4, 2024 · 0 comments
Labels
type: feature Introduction of new functionality.

Comments

@naerymdan
Copy link

naerymdan commented Apr 4, 2024

I have an external set of opening hours that might or might not specify PH/SH. I do not have data for the country in question. I'd rather be able to still get general information form this library than the full stop error "no holiday definition".

Could we have something like:

new opening_hours(
  openingHours,  
  {
    lat: 41.328937, 
    lon: 19.818096,
    address: {
      country_code: "AL",
      state: 'N/A' 
    },
    {
      skip_ph: true,
      skip_sh: true 
    }
  }
);
@KristjanESPERANTO KristjanESPERANTO added the type: feature Introduction of new functionality. label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Introduction of new functionality.
Projects
None yet
Development

No branches or pull requests

2 participants