Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: RationalFunctionApproximation.jl: A Julia package for approximation by rational functions #5929

Closed
editorialbot opened this issue Oct 6, 2023 · 13 comments
Labels
Julia pre-review query-scope Submissions of uncertain scope for JOSS rejected TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @tobydriscoll (Tobin Driscoll)
Repository: https://github.com/complexvariables/RationalFunctionApproximation.jl
Branch with paper.md (empty if default branch): joss
Version: v0.1.0
Editor: Pending
Reviewers: Pending
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/21e9706b757f77ac17e14d3efe4c7f23"><img src="https://joss.theoj.org/papers/21e9706b757f77ac17e14d3efe4c7f23/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/21e9706b757f77ac17e14d3efe4c7f23/status.svg)](https://joss.theoj.org/papers/21e9706b757f77ac17e14d3efe4c7f23)

Author instructions

Thanks for submitting your paper to JOSS @tobydriscoll. Currently, there isn't a JOSS editor assigned to your paper.

@tobydriscoll if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Oct 6, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.07 s (478.0 files/s, 41194.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Julia                           16            201            123           1147
XML                              1              0              0            441
Markdown                         7            121              0            348
TeX                              2             13              0            188
YAML                             4              1              6            126
TOML                             2              6              0             37
-------------------------------------------------------------------------------
SUM:                            32            342            129           2287
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 992

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.4171/8ecm/16 is OK
- 10.1111/sapm.12548 is OK
- 10.1093/imanum/drab108 is OK
- 10.1007/s00211-019-01023-z is OK
- 10.1137/19m125947x is OK
- 10.1109/EPEPS.2017.8329756 is OK
- 10.1007/s10543-023-00959-x is OK
- 10.1137/16m1106122 is OK
- 10.1109/HPTCDL.2014.10 is OK

MISSING DOIs

- 10.1007/978-3-031-32412-3_9 may be a valid DOI for title: Rational Approximation Preconditioners for Multiphysics Problems
- 10.21105/joss.01811 may be a valid DOI for title: ComplexRegions.Jl: A Julia Package for Regions in the Complex Plane

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

LaplaceInterpolation.jl: A Julia package for fast interpolation on a grid
Submitting author: @lootie
Handling editor: @VivianePons (Retired)
Reviewers: @wkearn, @eviatarbach
Similarity score: 0.8318

Optim: A mathematical optimization package for Julia
Submitting author: @anriseth
Handling editor: @labarba (Retired)
Reviewers: @ahwillia
Similarity score: 0.8239

ComplexRegions.jl: A Julia package for regions in the complex plane
Submitting author: @tobydriscoll
Handling editor: @drvinceknight (Active)
Reviewers: @dlfivefifty, @dpsanders
Similarity score: 0.8197

TaylorSeries.jl: Taylor expansions in one and several variables in Julia
Submitting author: @lbenet
Handling editor: @jedbrown (Active)
Reviewers: @sriharikrishna, @tobydriscoll
Similarity score: 0.8182

PDENLPModels.jl: An NLPModel API for Optimization Problems with PDE-Constraints
Submitting author: @tmigot
Handling editor: @jbytecode (Active)
Reviewers: @jmejia8, @HaoZeke
Similarity score: 0.8020

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

@danielskatz
Copy link

👋 @tobydriscoll - thanks for your submission. Due to the relatively small amount of code and short commit history, the editors will now discuss if it meets the substantial scholarly effort criterion for review by JOSS. You should hear back in a week or so.

In addition, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

@danielskatz
Copy link

@editorialbot query scope

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Oct 6, 2023
@danielskatz
Copy link

Note that if this passes the scope review, @jbytecode has volunteered to edit it

@danielskatz
Copy link

👋 @tobydriscoll - I'm sorry to say that after discussion amongst the JOSS editors, we have decided that this submission does not meet the substantial scholarly effort criterion for review by JOSS. Please see https://joss.readthedocs.io/en/latest/submitting.html#other-venues-for-reviewing-and-publishing-software-packages for other suggestions for how you might receive credit for your work.

@danielskatz
Copy link

@editorialbot reject

@editorialbot
Copy link
Collaborator Author

Paper rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Julia pre-review query-scope Submissions of uncertain scope for JOSS rejected TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

2 participants