Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Minterpy: multivariate polynomial interpolation in Python #7619

Open
editorialbot opened this issue Dec 30, 2024 · 32 comments
Open
Labels
pre-review Python TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @damar-wicaksono (Damar Wicaksono)
Repository: https://github.com/minterpy-project/minterpy
Branch with paper.md (empty if default branch): dev-joss
Version: v0.3.0
Editor: Pending
Reviewers: Pending
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/96208a133980e518cdfdc36abdc504de"><img src="https://joss.theoj.org/papers/96208a133980e518cdfdc36abdc504de/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/96208a133980e518cdfdc36abdc504de/status.svg)](https://joss.theoj.org/papers/96208a133980e518cdfdc36abdc504de)

Author instructions

Thanks for submitting your paper to JOSS @damar-wicaksono. Currently, there isn't a JOSS editor assigned to your paper.

@damar-wicaksono if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Dec 30, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=0.22 s (984.6 files/s, 236151.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          78           4953          10866          10698
Jupyter Notebook                30              0          11473           5291
reStructuredText                86           1659           2012           2490
Markdown                         5            273              0            991
TeX                              2             70              1            568
YAML                            11             43             40            543
DOS Batch                        1              8              1             26
make                             1              4              7              9
TOML                             1              2              0              7
CSS                              1              1              0              6
INI                              1              0              0              3
-------------------------------------------------------------------------------
SUM:                           217           7013          24400          20632
-------------------------------------------------------------------------------

Commit count by author:

   274	Damar Wicaksono
    49	Sachin Krishnan Thekke Veettil
    46	MrMinimal64
    35	szabo
    32	Hernandez Acosta, Uwe (FWKH) - 13668
    28	Uwe Hernandez Acosta
     6	Wicaksono
     4	Michael Hecht
     2	JaninaSchreiber
     2	Sachin Krishnan T V
     2	Thekke Veettil, Sachin Krishnan (FWU) - 142348
     1	Jannik Michelfeit
     1	jschreib

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1103/physrevb.107.155148 is OK
- 10.1145/3583133.3590743 is OK
- 10.1137/22m1536510 is OK
- 10.1109/5.993400 is OK
- 10.1016/s0377-0427(02)00517-4 is OK
- 10.1007/978-3-030-01177-2_5 is OK
- 10.1090/s0002-9939-1959-0113131-7 is OK
- 10.1137/16m1066312 is OK
- 10.1016/j.jocs.2015.08.008 is OK
- 10.21105/joss.04249 is OK
- 10.1016/j.softx.2020.100450 is OK
- 10.21105/joss.00166 is OK
- 10.21105/joss.05489 is OK
- 10.1137/S1064827501387826 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.21105/joss.01745 is OK
- 10.1090/proc/13623 is OK
- 10.48550/ARXIV.2010.10824 is OK
- 10.48550/arXiv.2212.11706 is OK
- 10.1016/j.jat.2012.11.005 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Fast numerical methods for stochastic computations...
- No DOI given, and none found for title: Approximation theory and approximation practice, e...
- No DOI given, and none found for title: Six myths of polynomial interpolation and quadratu...
- No DOI given, and none found for title: Chebfun guide
- No DOI given, and none found for title: ApproxFun.jl: a Julia package for function approxi...
- No DOI given, and none found for title: ChebPy - a Python implementation of Chebfun
- No DOI given, and none found for title: pychebfun - Python Chebyshev functions
- No DOI given, and none found for title: Diátaxis documentation framework

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 2359

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Pyinterpolate: Spatial interpolation in Python for point measurements and aggregated datasets
Submitting author: @SimonMolinsky
Handling editor: @hugoledoux (Active)
Reviewers: @chrisbrunsdon, @kenohori, @sdesabbata
Similarity score: 0.6452

multivar_horner: A Python package for computing Horner factorisations of multivariate polynomials
Submitting author: @MrMinimal64
Handling editor: @dpsanders (Retired)
Reviewers: @henrik227, @saschatimme
Similarity score: 0.6421

ndsplines: A Python Library for Tensor-Product B-Splines of Arbitrary Dimension
Submitting author: @sixpearls
Handling editor: @mbobra (Active)
Reviewers: @amritagos, @sarats
Similarity score: 0.6280

Basix: a runtime finite element basis evaluation library
Submitting author: @mscroggs
Handling editor: @jedbrown (Active)
Reviewers: @tisaac, @wence-
Similarity score: 0.6208

DistributedSparseGrids.jl: A Julia library implementing an Adaptive Sparse Grid collocation method
Submitting author: @baxmittens
Handling editor: @drvinceknight (Active)
Reviewers: @ericneiva, @matt-graham
Similarity score: 0.6170

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@danielskatz
Copy link

👋 @damar-wicaksono - thanks for your submission. Note that your paper is about 2400 words long, while JOSS requests papers be roughly 250-1000 words. Please remove content from your paper, perhaps following the example paper. You might want to point from the paper to details in the repo or documentation, rather than putting all the details in the paper.

In addition, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect.

Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf after making changes to the .md file or when the references are right to make a new PDF. You can also use @editorialbot check repository to check a number of things, include the number of words in the paper.

editorialbot commands need to be the first entry in a new comment.

When you are ready to proceed, please ping me.

@damar-wicaksono
Copy link

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=0.21 s (1013.9 files/s, 242526.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          78           4953          10866          10698
Jupyter Notebook                30              0          11473           5291
reStructuredText                86           1659           2012           2490
Markdown                         5            266              0            866
TeX                              2             69              1            561
YAML                            11             43             40            543
DOS Batch                        1              8              1             26
make                             1              4              7              9
TOML                             1              2              0              7
CSS                              1              1              0              6
INI                              1              0              0              3
-------------------------------------------------------------------------------
SUM:                           217           7005          24400          20500
-------------------------------------------------------------------------------

Commit count by author:

   275	Damar Wicaksono
    49	Sachin Krishnan Thekke Veettil
    46	MrMinimal64
    35	szabo
    32	Hernandez Acosta, Uwe (FWKH) - 13668
    28	Uwe Hernandez Acosta
     6	Wicaksono
     4	Michael Hecht
     2	JaninaSchreiber
     2	Sachin Krishnan T V
     2	Thekke Veettil, Sachin Krishnan (FWU) - 142348
     1	Jannik Michelfeit
     1	jschreib

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1638

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@damar-wicaksono
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1103/physrevb.107.155148 is OK
- 10.1145/3583133.3590743 is OK
- 10.1137/22m1536510 is OK
- 10.1109/5.993400 is OK
- 10.1016/s0377-0427(02)00517-4 is OK
- 10.1007/978-3-030-01177-2_5 is OK
- 10.1090/s0002-9939-1959-0113131-7 is OK
- 10.1137/16m1066312 is OK
- 10.1016/j.jocs.2015.08.008 is OK
- 10.21105/joss.04249 is OK
- 10.1016/j.softx.2020.100450 is OK
- 10.21105/joss.00166 is OK
- 10.21105/joss.05489 is OK
- 10.1137/S1064827501387826 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.21105/joss.01745 is OK
- 10.1090/proc/13623 is OK
- 10.48550/ARXIV.2010.10824 is OK
- 10.48550/arXiv.2212.11706 is OK
- 10.1016/j.jat.2012.11.005 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Fast numerical methods for stochastic computations...
- No DOI given, and none found for title: Approximation theory and approximation practice, e...
- No DOI given, and none found for title: Six myths of polynomial interpolation and quadratu...
- No DOI given, and none found for title: Chebfun guide
- No DOI given, and none found for title: ApproxFun.jl: a Julia package for function approxi...
- No DOI given, and none found for title: ChebPy - a Python implementation of Chebfun
- No DOI given, and none found for title: pychebfun - Python Chebyshev functions

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@damar-wicaksono
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

LaplaceInterpolation.jl: A Julia package for fast interpolation on a grid
Submitting author: @lootie
Handling editor: @VivianePons (Retired)
Reviewers: @wkearn, @eviatarbach
Similarity score: 0.6593

Pyinterpolate: Spatial interpolation in Python for point measurements and aggregated datasets
Submitting author: @SimonMolinsky
Handling editor: @hugoledoux (Active)
Reviewers: @chrisbrunsdon, @kenohori, @sdesabbata
Similarity score: 0.6383

DistributedSparseGrids.jl: A Julia library implementing an Adaptive Sparse Grid collocation method
Submitting author: @baxmittens
Handling editor: @drvinceknight (Active)
Reviewers: @ericneiva, @matt-graham
Similarity score: 0.6357

ndsplines: A Python Library for Tensor-Product B-Splines of Arbitrary Dimension
Submitting author: @sixpearls
Handling editor: @mbobra (Active)
Reviewers: @amritagos, @sarats
Similarity score: 0.6326

MParT: Monotone Parameterization Toolkit
Submitting author: @mparno
Handling editor: @diehlpk (Active)
Reviewers: @ansgarwenzel, @f-t-s
Similarity score: 0.6229

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@damar-wicaksono
Copy link

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=0.22 s (1008.4 files/s, 241245.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          78           4953          10866          10698
Jupyter Notebook                30              0          11473           5291
reStructuredText                86           1659           2012           2490
Markdown                         5            264              0            879
TeX                              2             69              1            561
YAML                            11             43             40            543
DOS Batch                        1              8              1             26
make                             1              4              7              9
TOML                             1              2              0              7
CSS                              1              1              0              6
INI                              1              0              0              3
-------------------------------------------------------------------------------
SUM:                           217           7003          24400          20513
-------------------------------------------------------------------------------

Commit count by author:

   275	Damar Wicaksono
    49	Sachin Krishnan Thekke Veettil
    46	MrMinimal64
    35	szabo
    32	Hernandez Acosta, Uwe (FWKH) - 13668
    28	Uwe Hernandez Acosta
     6	Wicaksono
     4	Michael Hecht
     2	JaninaSchreiber
     2	Sachin Krishnan T V
     2	Thekke Veettil, Sachin Krishnan (FWU) - 142348
     1	Jannik Michelfeit
     1	jschreib

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1599

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@damar-wicaksono
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1103/physrevb.107.155148 is OK
- 10.1145/3583133.3590743 is OK
- 10.1137/22m1536510 is OK
- 10.1109/5.993400 is OK
- 10.1016/s0377-0427(02)00517-4 is OK
- 10.1007/978-3-030-01177-2_5 is OK
- 10.1090/s0002-9939-1959-0113131-7 is OK
- 10.1137/16m1066312 is OK
- 10.1016/j.jocs.2015.08.008 is OK
- 10.21105/joss.04249 is OK
- 10.1016/j.softx.2020.100450 is OK
- 10.21105/joss.00166 is OK
- 10.21105/joss.05489 is OK
- 10.1137/S1064827501387826 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.21105/joss.01745 is OK
- 10.1090/proc/13623 is OK
- 10.48550/ARXIV.2010.10824 is OK
- 10.48550/arXiv.2212.11706 is OK
- 10.1016/j.jat.2012.11.005 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Fast numerical methods for stochastic computations...
- No DOI given, and none found for title: Approximation theory and approximation practice, e...
- No DOI given, and none found for title: Six myths of polynomial interpolation and quadratu...
- No DOI given, and none found for title: Chebfun guide
- No DOI given, and none found for title: ApproxFun.jl: a Julia package for function approxi...
- No DOI given, and none found for title: ChebPy - a Python implementation of Chebfun
- No DOI given, and none found for title: pychebfun - Python Chebyshev functions

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@damar-wicaksono
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

LaplaceInterpolation.jl: A Julia package for fast interpolation on a grid
Submitting author: @lootie
Handling editor: @VivianePons (Retired)
Reviewers: @wkearn, @eviatarbach
Similarity score: 0.6538

Pyinterpolate: Spatial interpolation in Python for point measurements and aggregated datasets
Submitting author: @SimonMolinsky
Handling editor: @hugoledoux (Active)
Reviewers: @chrisbrunsdon, @kenohori, @sdesabbata
Similarity score: 0.6303

DistributedSparseGrids.jl: A Julia library implementing an Adaptive Sparse Grid collocation method
Submitting author: @baxmittens
Handling editor: @drvinceknight (Active)
Reviewers: @ericneiva, @matt-graham
Similarity score: 0.6219

ndsplines: A Python Library for Tensor-Product B-Splines of Arbitrary Dimension
Submitting author: @sixpearls
Handling editor: @mbobra (Active)
Reviewers: @amritagos, @sarats
Similarity score: 0.6157

starry_process: Interpretable Gaussian processes for stellar light curves
Submitting author: @rodluger
Handling editor: @arfon (Active)
Reviewers: @nespinoza, @j-faria
Similarity score: 0.6119

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@damar-wicaksono
Copy link

@danielskatz: Thank you very much for handling our submission. Following your suggestion, we have revised the manuscript and significantly reduced its number of words by removing unnecessary details; they can still be found in the online documentation. I hope that it's okay.

We also carefully reviewed the list of references and were unable to locate the missing DOI for some papers as flagged by the bot.

Thank you again!

@danielskatz
Copy link

Thanks @damar-wicaksono.

And DOIs aren't needed for all references, just DOIs for references where there is a DOI...

@danielskatz
Copy link

👋 @jedbrown - would you be able to edit this submission?

@danielskatz
Copy link

@editorialbot invite @jedbrown as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@danielskatz
Copy link

👋 @jedbrown - I wanted to check with you again, now after the holidays, to see if you can edit this submission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

3 participants