Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: BacktestGraphics in R #7622

Closed
editorialbot opened this issue Jan 2, 2025 · 36 comments
Closed

[PRE REVIEW]: BacktestGraphics in R #7622

editorialbot opened this issue Jan 2, 2025 · 36 comments
Labels
pre-review query-scope Submissions of uncertain scope for JOSS R rejected TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @yanrong-stacy-song (Yanrong Song)
Repository: https://github.com/yanrong-stacy-song/backtestGraphics
Branch with paper.md (empty if default branch): main
Version: v0.1.8
Editor: Pending
Reviewers: Pending
Managing EiC: Chris Vernon

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/4efd59f1ea09617d4dc805a19d2b3c8e"><img src="https://joss.theoj.org/papers/4efd59f1ea09617d4dc805a19d2b3c8e/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/4efd59f1ea09617d4dc805a19d2b3c8e/status.svg)](https://joss.theoj.org/papers/4efd59f1ea09617d4dc805a19d2b3c8e)

Author instructions

Thanks for submitting your paper to JOSS @yanrong-stacy-song. Currently, there isn't a JOSS editor assigned to your paper.

@yanrong-stacy-song if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning labels Jan 2, 2025
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=0.02 s (1908.6 files/s, 142788.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                               26            318            686            736
TeX                              3            119             54            314
Markdown                         2             38              0             76
JSON                             1              2              0             51
-------------------------------------------------------------------------------
SUM:                            32            477            740           1177
-------------------------------------------------------------------------------

Commit count by author:

    12	yanrong_stacy_song
     7	knightsay

@editorialbot
Copy link
Collaborator Author

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 608

🔴 Failed to discover a Statement of need section in paper

@editorialbot
Copy link
Collaborator Author

License info:

🔴 Failed to discover a valid open source license

@editorialbot
Copy link
Collaborator Author

Hello @yanrong-stacy-song, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Run checks and provide information on the repository and the paper file
@editorialbot check repository

# Check the references of the paper for missing DOIs
@editorialbot check references

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@yanrong-stacy-song
Copy link

Paper file info:

📄 Wordcount for paper.md is 608

🔴 Failed to discover a Statement of need section in paper

I have added the Statement of need section in paper.md and pushed the changes to Github

@yanrong-stacy-song
Copy link

⚠️ An error happened when generating the pdf.

I have fixed paper.md and set up the JOSS PDF generator in Github actions and successfully compiled the PDF there

@yanrong-stacy-song
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

autoplotly: An R package for automatic generation of interactive visualizations for statistical results
Submitting author: @terrytangyuan
Handling editor: @arfon (Active)
Reviewers: @chlalanne, @corybrunson
Similarity score: 0.7047

StatAid: An R package with a graphical user interface for data analysis
Submitting author: @VincentAlcazer
Handling editor: @mikldk (Retired)
Reviewers: @nistara, @adithirgis
Similarity score: 0.6864

Makie.jl: Flexible high-performance data visualization for Julia
Submitting author: @jkrumbiegel
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @fverdugo, @gaelforget
Similarity score: 0.6859

greeks: Sensitivities of Prices of Financial Options and Implied Volatilities
Submitting author: @ahudde
Handling editor: @csoneson (Active)
Reviewers: @lrnv, @bahung
Similarity score: 0.6821

Building, Importing, and Exporting GEXF Graph Files with rgexf
Submitting author: @gvegayon
Handling editor: @fabian-s (Active)
Reviewers: @jonjoncardoso, @corneliusfritz
Similarity score: 0.6801

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@yanrong-stacy-song
Copy link

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=0.02 s (2051.7 files/s, 151704.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                               26            318            686            736
TeX                              3            119             54            314
Markdown                         2             38              0             92
JSON                             1              2              0             51
YAML                             1              1              4             25
-------------------------------------------------------------------------------
SUM:                            33            478            744           1218
-------------------------------------------------------------------------------

Commit count by author:

    17	yanrong_stacy_song
     8	knightsay

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 742

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🔴 Failed to discover a valid open source license

@yanrong-stacy-song
Copy link

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=0.02 s (2060.4 files/s, 132961.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                               26            318            686            736
TeX                              2             15              0             97
Markdown                         2             38              0             92
JSON                             1              2              0             51
YAML                             1              1              4             25
-------------------------------------------------------------------------------
SUM:                            32            374            690           1001
-------------------------------------------------------------------------------

Commit count by author:

    17	yanrong_stacy_song
    10	knightsay

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 742

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

@yanrong-stacy-song
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

autoplotly: An R package for automatic generation of interactive visualizations for statistical results
Submitting author: @terrytangyuan
Handling editor: @arfon (Active)
Reviewers: @chlalanne, @corybrunson
Similarity score: 0.7049

StatAid: An R package with a graphical user interface for data analysis
Submitting author: @VincentAlcazer
Handling editor: @mikldk (Retired)
Reviewers: @nistara, @adithirgis
Similarity score: 0.6861

Makie.jl: Flexible high-performance data visualization for Julia
Submitting author: @jkrumbiegel
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @fverdugo, @gaelforget
Similarity score: 0.6857

greeks: Sensitivities of Prices of Financial Options and Implied Volatilities
Submitting author: @ahudde
Handling editor: @csoneson (Active)
Reviewers: @lrnv, @bahung
Similarity score: 0.6821

Building, Importing, and Exporting GEXF Graph Files with rgexf
Submitting author: @gvegayon
Handling editor: @fabian-s (Active)
Reviewers: @jonjoncardoso, @corneliusfritz
Similarity score: 0.6802

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@yanrong-stacy-song
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- None

🟡 SKIP DOIs

- No DOI given, and none found for title: Backtests
- No DOI given, and none found for title: Time Series Visualization with Cubism.js
- No DOI given, and none found for title: Quantitative Value
- No DOI given, and none found for title: shiny: Web Application Framework for R

❌ MISSING DOIs

- 10.32614/cran.package.dygraphs may be a valid DOI for title: dygraphs: Interface to Dygraphs Interactive Time S...

❌ INVALID DOIs

- None

@yanrong-stacy-song
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.32614/CRAN.package.backtest is OK
- 10.1002/9781119205456 is OK
- 10.32614/CRAN.package.dygraphs is OK
- 10.32614/CRAN.package.shiny is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Time Series Visualization with Cubism.js

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@yanrong-stacy-song
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

autoplotly: An R package for automatic generation of interactive visualizations for statistical results
Submitting author: @terrytangyuan
Handling editor: @arfon (Active)
Reviewers: @chlalanne, @corybrunson
Similarity score: 0.7050

StatAid: An R package with a graphical user interface for data analysis
Submitting author: @VincentAlcazer
Handling editor: @mikldk (Retired)
Reviewers: @nistara, @adithirgis
Similarity score: 0.6864

Makie.jl: Flexible high-performance data visualization for Julia
Submitting author: @jkrumbiegel
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @fverdugo, @gaelforget
Similarity score: 0.6859

greeks: Sensitivities of Prices of Financial Options and Implied Volatilities
Submitting author: @ahudde
Handling editor: @csoneson (Active)
Reviewers: @lrnv, @bahung
Similarity score: 0.6818

Building, Importing, and Exporting GEXF Graph Files with rgexf
Submitting author: @gvegayon
Handling editor: @fabian-s (Active)
Reviewers: @jonjoncardoso, @corneliusfritz
Similarity score: 0.6801

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@yanrong-stacy-song
Copy link

@editorialbot generate my checklist

@editorialbot
Copy link
Collaborator Author

Checklists can only be created once the review has started in the review issue

@crvernon
Copy link

crvernon commented Jan 3, 2025

@editorialbot query scope

👋 @yanrong-stacy-song - I am going to run this by our larger editorial board to ensure that it meets scope requirements for JOSS. I'll be back in touch ASAP. Thanks.

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Jan 3, 2025
@crvernon
Copy link

@editorialbot reject

👋 @yanrong-stacy-song - at this time we must reject this submission due to it not meeting our substantial scholarly effort requirements per the following:

  • Code base too small
  • Code base too young (short commit history)

Thank you.

@editorialbot
Copy link
Collaborator Author

Paper rejected.

@yanrong-stacy-song
Copy link

@crvernon Thanks for replying! We understand the number of lines of R code is smaller than 1000 in the cloc output, but just want to comment on the second point of short commit history:

  1. The project was previously hosted at https://github.com/knightsay/backtestGraphics (co-author Zijie's repo) but he has limited time to work on subsequent improvements, so I became the maintainer and Zijie transferred the repo to be hosted in my Github
  2. The project was initially submitted to JOSS at [REVIEW]: Backtest Graphics #30 back in 2018, by our co-author Karan, but he was still in college and didn't push the submission to the finish line.

Based on these, do you think this project can meet the substantial scholarly effort requirement? Thx again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review query-scope Submissions of uncertain scope for JOSS R rejected TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Development

No branches or pull requests

3 participants