Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link checker broken (aka What happened with PR #841?) #858

Closed
Relequestual opened this issue Apr 1, 2022 · 2 comments · Fixed by #862
Closed

Link checker broken (aka What happened with PR #841?) #858

Relequestual opened this issue Apr 1, 2022 · 2 comments · Fixed by #862

Comments

@Relequestual
Copy link
Contributor

Relequestual commented Apr 1, 2022

PR #841 had checks run which came back OK.
https://github.com/openjs-foundation/cross-project-council/pull/841/checks

However, when you look at the latest commit, 821d460 you can see a check failed: https://github.com/openjs-foundation/cross-project-council/runs/5759210379

Currently, the links are broken =[
What happened @joesepi ?

(For the avoidance of doubt, I'm not trying to point a finger here and say someone did something wrong. I'm meerly trying to figure out what happened and why, and @joesepi might know in this instance.)

@Relequestual
Copy link
Contributor Author

I THINK I've worked out what happened.

The URLs which fail on the commit but not the PR are all ones with fully qualified URLs.

As a result, they are FINE in the PR, but once deployed, they no longer work.

It looks like this should be fixable using a newer version of the link checker.
In combination with configuration for URL rewriting, server root, and directory listing.

I'll see if I can verify this locally and make a PR.

@joesepi
Copy link
Member

joesepi commented Apr 4, 2022

Thanks @Relequestual for noticing and looking into this. 🙌

@Relequestual Relequestual changed the title What happened with PR #841? Link checker broken (aka What happened with PR #841?) Apr 5, 2022
@bnb bnb closed this as completed in #862 Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants