From 609609aefd64248287f084768c298fff03243d01 Mon Sep 17 00:00:00 2001
From: Ian <ian_bacher@brown.edu>
Date: Mon, 19 Dec 2022 11:23:05 -0500
Subject: [PATCH] (feat) Support for an encounter of previous obs values

---
 .../historical-expression-helper-service.ts   | 23 +++++++++++--------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/projects/ngx-formentry/src/form-entry/helpers/historical-expression-helper-service.ts b/projects/ngx-formentry/src/form-entry/helpers/historical-expression-helper-service.ts
index 05429b4d..68e72fa5 100644
--- a/projects/ngx-formentry/src/form-entry/helpers/historical-expression-helper-service.ts
+++ b/projects/ngx-formentry/src/form-entry/helpers/historical-expression-helper-service.ts
@@ -14,19 +14,22 @@ export class HistoricalHelperService {
 
   public evaluate(
     expr: string,
-    dataSources: any,
-    additionalScopevalues: any
-  ): any {
+    dataSources: Record<string, unknown>,
+    additionalScopeValues: Record<string, unknown> | null,
+  ) {
     const HD = new HistoricalEncounterDataService();
     HD.registerEncounters('prevEnc', dataSources['rawPrevEnc']);
-    const deps: any = {
-      HD: HD
-    };
+    if (dataSources.hasOwnProperty('rawPrevObs')) {
+      HD.registerEncounters('prevObs', dataSources['rawPrevObs']);
+    }
+
+    const deps = { HD };
 
-    if (additionalScopevalues) {
-      for (const o in additionalScopevalues) {
-        if (additionalScopevalues[o]) {
-          deps[o] = additionalScopevalues[o];
+    if (additionalScopeValues) {
+      for (const o in additionalScopeValues) {
+        const value = additionalScopeValues[o];
+        if (typeof value !== 'undefined' && value !== null) {
+          deps[o] = value;
         }
       }
     }