-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(enhancement) bump styling to carbon 11 for form-entry engine #1
Conversation
b809f1b
to
1a6087a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@donaldkibet Thanks for this! Some nit-picky changes are necessary, but broadly this looks good.
.github/workflows/main.yml
Outdated
@@ -36,7 +36,7 @@ jobs: | |||
with: | |||
node-version: "16" | |||
cache: "npm" | |||
- run: yarn install --frozen-lockfile | |||
- run: yarn install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- run: yarn install | |
- run: yarn install --frozen-lockfile |
.gitignore
Outdated
@@ -16,6 +16,7 @@ | |||
*.launch | |||
.settings/ | |||
*.sublime-workspace | |||
.yarn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.yarn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're moving this repo over to Yarn 3, please see the Yarn docs for what needs to be in the .gitignore.
@@ -13,7 +13,7 @@ | |||
"e2e": "ng e2e" | |||
}, | |||
"peerDependencies": { | |||
"carbon-components": "10.x" | |||
"@carbon/styles": "1.x" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a dependency, not a peer dependency (it isn't provided at runtime).
@@ -0,0 +1,9 @@ | |||
/* You can add global styles to this file, and also import other style files */ | |||
@import '~@carbon/styles/css/styles.min.css'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@import '~@carbon/styles/css/styles.min.css'; | |
@import '~@carbon/styles'; |
.github/workflows/main.yml
Outdated
@@ -36,7 +36,7 @@ jobs: | |||
with: | |||
node-version: "16" | |||
cache: "npm" | |||
- run: yarn install --frozen-lockfile | |||
- run: yarn install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- run: yarn install | |
- run: yarn install --frozen-lockfile |
Or for Yarn v3:
- run: yarn install | |
- run: yarn install --immutable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yarn lock files needs to be updated since i am bumping the carbon dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The yarn lock files need to be updated, but that should be part of your commit. By the time CI is running, the yarn lock file shouldn't need to be updated (this is basically the use-case for this flag).
88e3da3
to
b323c82
Compare
b323c82
to
06c294c
Compare
Thanks @donaldkibet! |
Requirements
Summary
Screenshots
None.
Issue
None.
Other
None.