Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if GT is still robust after the major releases they had #299

Closed
timtreis opened this issue Jan 10, 2022 · 2 comments · Fixed by #361
Closed

Check if GT is still robust after the major releases they had #299

timtreis opened this issue Jan 10, 2022 · 2 comments · Fixed by #361
Assignees
Labels
bug Something isn't working issue Used for project filtering
Milestone

Comments

@timtreis
Copy link
Collaborator

timtreis commented Jan 10, 2022

Daniel (gtsummary) mentioned that GT had a big release and made major changes to their API. We're requiring GT 0.1.0, which was supposedly pre-CRAN? maybe me should check if our old code still runs without problems.

@cschaerfe

@timtreis timtreis added bug Something isn't working issue Used for project filtering labels Jan 10, 2022
@timtreis timtreis changed the title Check if GT is still robust after the releases they ahd Check if GT is still robust after the major releases they had Jan 10, 2022
@SHAESEN2
Copy link
Collaborator

Can we also remove the dependency on glue? and only import the pipe from magrittr?

@ddsjoberg
Copy link
Collaborator

The gt package was at version 0.1.0 throughout its pre-CRAN development. I don't recall exactly when, but there was a major update to the internals and some of the functions one one point. I think it was after the first CRAN release, but I am not 100% certain.

Since gt is in the Suggests section, the version will never be checked FYI. Perhaps at the top of the gt section of render() you could add rlang::check_installed("gt", version = "0.3.1") to add a version check. It's also difficult to check old versions of pkgs. If you suspect there have been breaking changes in a pkg, I would suggest increasing the min required version to avoid potential issues.

@SHAESEN2 SHAESEN2 added this to the v0.3.0 milestone Feb 26, 2022
@SHAESEN2 SHAESEN2 assigned ddsjoberg and unassigned cschaerfe May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working issue Used for project filtering
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants