Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a contributor guide #325

Closed
SHAESEN2 opened this issue Feb 26, 2022 · 4 comments
Closed

Create a contributor guide #325

SHAESEN2 opened this issue Feb 26, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request idea To post an idea for a new plot
Milestone

Comments

@SHAESEN2
Copy link
Collaborator

Idea

What is your idea for a new plot/table?

Do you have any examples you can share of what it looks like?

What potential packages/functions could be used to make this plot?

Are you interested to implement this yourself?

@SHAESEN2 SHAESEN2 added enhancement New feature or request idea To post an idea for a new plot labels Feb 26, 2022
@SHAESEN2 SHAESEN2 added this to the v0.3.0 milestone Feb 26, 2022
@SHAESEN2
Copy link
Collaborator Author

Updating the wiki might be easier.

@ddsjoberg
Copy link
Collaborator

Update with details

  • tibbles vs data.frames
  • use of $ internally
  • details on the unit testing framework that has been implemented (sometimes when I do a full check of the package, the entire test file is deleted and re-saved with some changes to the header, I think). As this is a non-standard workflow, details for contributors would be incredibly useful
  • add details for expectations of testing for new PRs. the package has amazing testing coverage, but as a new contributor is was difficult to orient myself on how to integrate my own unit tests

@SHAESEN2 SHAESEN2 reopened this Apr 19, 2022
@SHAESEN2
Copy link
Collaborator Author

Updated Wiki.

@cschaerfe
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request idea To post an idea for a new plot
Projects
None yet
Development

No branches or pull requests

3 participants