Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling package #334

Closed
SHAESEN2 opened this issue Feb 26, 2022 · 4 comments · Fixed by #414
Closed

Styling package #334

SHAESEN2 opened this issue Feb 26, 2022 · 4 comments · Fixed by #414
Assignees
Labels
discussion Discussion around design choices and architecture enhancement New feature or request
Milestone

Comments

@SHAESEN2
Copy link
Collaborator

Should we implement a consistent style?
Adopt a coding style guideline…consider those utilized by styler::style_pkg(). It’s great for projects with many contributors to maintain a consistent syntax style.

@SHAESEN2 SHAESEN2 added enhancement New feature or request discussion Discussion around design choices and architecture labels Feb 26, 2022
@timtreis
Copy link
Collaborator

timtreis commented Mar 1, 2022

Very much in favour of this one 👍

@SHAESEN2 SHAESEN2 added this to the v0.3.0 milestone Mar 28, 2022
@SHAESEN2
Copy link
Collaborator Author

Propose to add this to a PR template so that the package maintains a consistent style

@lorenzwalthert
Copy link

lorenzwalthert commented Apr 13, 2022

Maintainer of {styler} here. You could also use one of the third-party integrations to enforce a consistent style.

@bailliem bailliem self-assigned this Apr 19, 2022
@SHAESEN2
Copy link
Collaborator Author

SHAESEN2 commented May 9, 2022

We will be doing the styling within each PR, rather than relying on third-party integration for efficiency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussion around design choices and architecture enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants