Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share identical compilation units directly between http and stream modules #24

Open
agentzh opened this issue Jan 22, 2018 · 2 comments

Comments

@agentzh
Copy link
Member

agentzh commented Jan 22, 2018

Some compilations units like shdict.c, string.c, lex.c, regex.c, and etc, could share the object code directly between http and stream modules in the final nginx executable. We could simply make the http and stream lua module depend on this meta lua module not only at codegen time, but also at compile and link time :)

@agentzh
Copy link
Member Author

agentzh commented Jan 22, 2018

This can make the resulting binary smaller by avoiding binary code duplication in the final executable.

@thibaultcha
Copy link
Member

Proposal here: #76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants