Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sqlalchemy #598

Closed
rebkwok opened this issue Jul 5, 2022 · 0 comments · Fixed by #599
Closed

Upgrade sqlalchemy #598

rebkwok opened this issue Jul 5, 2022 · 0 comments · Fixed by #599
Assignees

Comments

@rebkwok
Copy link
Contributor

rebkwok commented Jul 5, 2022

sqlalchemy is currently pinned to version 1.4.27 because upgrading past 1.4.27 results in warnings which cause test errors, e.g.:

SAWarning: Dialect mssql:pymssql will not make use of SQL compilation caching as it does not set the 'supports_statement_cache' attribute to True. This can have significant performance implications including some performance degradations in comparison to prior SQLAlchemy versions. Dialect maintainers should seek to set this attribute to True after appropriate development and testing for SQLAlchemy 1.4 caching support. Alternatively, this attribute may be set to False which will disable this warning.

All our engine dialects inherit from base classes that include supports_statement_cache = True, but as of v1.4.28 (not 1.4.5 as it says in the docs), sqlalchemy requires third party dialects to explicitly declare that too.

We should be able to fix this by just adding supports_statement_cache = True to each dialect

@rebkwok rebkwok self-assigned this Jul 5, 2022
@rebkwok rebkwok added this to Data Team Jul 5, 2022
@rebkwok rebkwok moved this to In Progress in Data Team Jul 5, 2022
Repository owner moved this from In Progress to Done in Data Team Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant