Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Schema and DATAFORMAT don't clearly define DNP components #466

Closed
InRe-Dan opened this issue Sep 5, 2024 · 2 comments
Closed

JSON Schema and DATAFORMAT don't clearly define DNP components #466

InRe-Dan opened this issue Sep 5, 2024 · 2 comments

Comments

@InRe-Dan
Copy link

InRe-Dan commented Sep 5, 2024

It doesn't look like I can define a DNP component using a JSON file and the generate_interactive_bom.py script. DATAFORMAT.md implies that there can be a bom field on the pcbdata struct, but if I add such a field, the script gives me errors (fair enough - the schema doesn't define anything to do with bom or DNP components as far as I can tell). The config struct in DATAFORMAT.md also doesn't seem to be something that I can define in the JSON either.

What am I missing here? Or are these features not supported via the script?

@qu1ck
Copy link
Member

qu1ck commented Sep 5, 2024

Bom field in pcbdata is generated from your input and config, it is intentionally not in the json schema.

To have a DNP component you just have to add an extra field "dnp": "true" and then use that field with --dnp-field=dnp on command line.

@InRe-Dan
Copy link
Author

InRe-Dan commented Sep 5, 2024

Brilliant, thank you so much.

@InRe-Dan InRe-Dan closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants