From f1b750b8d35aea7e0a7edad6c31b486e2ef50ca8 Mon Sep 17 00:00:00 2001
From: Josh Romero <rmerqg@amazon.com>
Date: Fri, 4 Nov 2022 00:24:23 +0000
Subject: [PATCH] [VisBuilder] Add TODOs with issue links, fix test ID

Restores previous test ID for count field button

Signed-off-by: Josh Romero <rmerqg@amazon.com>
---
 .../public/application/components/data_tab/field.tsx           | 1 +
 .../public/application/components/data_tab/field_selector.tsx  | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/src/plugins/vis_builder/public/application/components/data_tab/field.tsx b/src/plugins/vis_builder/public/application/components/data_tab/field.tsx
index 7ab3659ec187..287c6aed621c 100644
--- a/src/plugins/vis_builder/public/application/components/data_tab/field.tsx
+++ b/src/plugins/vis_builder/public/application/components/data_tab/field.tsx
@@ -65,6 +65,7 @@ export const Field = ({ field, getDetails }: FieldProps) => {
       closePopover={() => setOpen(false)}
       anchorPosition="rightUp"
       panelClassName="vbItem__fieldPopoverPanel"
+      // TODO: make reposition on scroll actually work: https://github.com/opensearch-project/OpenSearch-Dashboards/issues/2782
       repositionOnScroll
       data-test-subj="field-popover"
     >
diff --git a/src/plugins/vis_builder/public/application/components/data_tab/field_selector.tsx b/src/plugins/vis_builder/public/application/components/data_tab/field_selector.tsx
index e0fad14a000b..5c82419d5531 100644
--- a/src/plugins/vis_builder/public/application/components/data_tab/field_selector.tsx
+++ b/src/plugins/vis_builder/public/application/components/data_tab/field_selector.tsx
@@ -26,6 +26,7 @@ interface IFieldCategories {
 export const FieldSelector = () => {
   const indexPattern = useIndexPatterns().selected;
   const fieldSearchValue = useTypedSelector((state) => state.visualization.searchField);
+  // TODO: instead of a single fetch of sampled hits for all fields, we should just use the agg service to get top hits or terms per field: https://github.com/opensearch-project/OpenSearch-Dashboards/issues/2780
   const hits = useSampleHits();
   const [filteredFields, setFilteredFields] = useState<IndexPatternField[]>([]);
 
@@ -77,6 +78,8 @@ export const FieldSelector = () => {
         <DraggableFieldButton
           field={{ name: 'count', displayName: 'Count', type: 'number' }}
           dragValue={COUNT_FIELD}
+          // TODO: improve the test ID for the Count field (or use a non-conflicting `name` value) and update functional test accordingly: https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/6f4125c9823f8e54e138076737ca16f011cbd7e7/cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/vis_builder/vis_types/metric.spec.js#L36
+          dataTestSubj="field-undefined-showDetails"
         />
         <FieldGroup
           id="categoricalFields"