Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MD] Add fetch_and_decrypt() #1926

Closed
Tracked by #1733
noCharger opened this issue Jul 21, 2022 · 1 comment
Closed
Tracked by #1733

[MD] Add fetch_and_decrypt() #1926

noCharger opened this issue Jul 21, 2022 · 1 comment
Labels
multiple datasource multiple datasource project

Comments

@noCharger
Copy link
Contributor

noCharger commented Jul 21, 2022

This function will fetch the credential by id and return the decrypted field

@noCharger
Copy link
Contributor Author

Exposing the fetch and decrypt() method is less recommended because we need to import credential management service to core, plus we need to take saved object client as a dependency. Given that core.dataService already requires a saved object client as a dependency for fetching data sources, it's logical to get credential object on data service layer and only use decrypt() as a utility method.

Talked with @zhongnansu offline and we came to an agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multiple datasource multiple datasource project
Projects
None yet
Development

No branches or pull requests

2 participants