Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VizBuilder] Implement cancel, save, save and return button flow on TopNav #2383

Open
abbyhu2000 opened this issue Sep 16, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request vis builder

Comments

@abbyhu2000
Copy link
Member

Subtask of #960

When creating a new wizard from dashboard, the topnav should have:

  1. cancel should discard the current changes and go back to dashboard
  2. save button should show save modal

Screen Shot 2022-09-16 at 2 58 48 PM

Save visualization

When editing an existing wizard from dashboard, the topnav should have:

  1. cancel button should discard the current changes
  2. save as button should show save modal
  3. save and return should save all the changes to the existing wizard and return to dashboard

Inspect Share Cancel Save asSave visualization

@abbyhu2000 abbyhu2000 added enhancement New feature or request vis builder labels Sep 16, 2022
@abbyhu2000 abbyhu2000 self-assigned this Sep 16, 2022
@abbyhu2000 abbyhu2000 changed the title [VizBuilder] Create a new wizard directly on dashboard [VizBuilder] Implement cancel, save, save and return button flow on TopNav Sep 16, 2022
@ashwin-pc
Copy link
Member

@btzeng In the case of Save and Return, does the "Add to Dashboard after saving" toggle still make sense?

@abbyhu2000
Copy link
Member Author

abbyhu2000 commented Sep 16, 2022

@btzeng In the case of Save and Return, does the "Add to Dashboard after saving" toggle still make sense?

i think it does make sense since it provides an option for user to create a new visualization/wizard(cuz user can turn save as new visualization toggle on) and then save this new one to the dashboard? @ashwin-pc Save and Return only save the changes to the old wizard, it doesn't create a new one.

@ahopp
Copy link
Contributor

ahopp commented Sep 21, 2022

@btzeng In the case of Save and Return, does the "Add to Dashboard after saving" toggle still make sense?

Echoing @abbyhu2000 on this one, I also think it makes sense. Provide another option to safe with new, IMO. And it doesn't seem to decrement the user flow in any meaningful way.

@joshuarrrr
Copy link
Member

@abbyhu2000 Is this done and ready to be closed? It looks like the parent issue is closed and complete.

@ashwin-pc
Copy link
Member

@joshuarrrr I think we want to keep this issue open since we have a draft PR open to add the cancel flow. That PR is still in draft because we realized that we were implementing sketchy UX patterns to enable these save and cancel flows. @KrooshalUX is working on a better save workflow that we can use across the app.

@KrooshalUX do we have a tracking issue for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vis builder
Projects
None yet
Development

No branches or pull requests

4 participants